Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] implement append, commit and flush for spann segment and index #3084

Merged
merged 14 commits into from
Dec 4, 2024
Merged

[ENH] implement append, commit and flush for spann segment and index #3084

merged 14 commits into from
Dec 4, 2024

Conversation

sanketkedia
Copy link
Contributor

@sanketkedia sanketkedia commented Nov 6, 2024 •
edited
Loading

Description of changes

Summarize the changes made by this PR.

  • New functionality
    • Implement append, commit and flush for spann segment and index. Current implementation does split and/or reassign. They will be followed up in the next PR.

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

None

@sanketkedia sanketkedia marked this pull request as ready for review November 6, 2024 21:14
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024

Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas

This was referenced Nov 6, 2024
Merged
Merged
Merged
@sanketkedia Graphite App
Copy link
Contributor Author

sanketkedia commented Nov 6, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sanketkedia sanketkedia mentioned this pull request Nov 6, 2024
Merged
1 task
@sanketkedia sanketkedia force-pushed the 11-06-implement_apply_materialized branch from 1524356 to 2b3388f Compare November 6, 2024 22:01
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024

Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2024

Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas

@sanketkedia sanketkedia force-pushed the 11-05-spann_segment_impl branch from 57d5c92 to 1a18963 Compare November 11, 2024 02:50
@sanketkedia sanketkedia force-pushed the 11-06-implement_apply_materialized branch from f7b4553 to 99dfd9b Compare November 11, 2024 02:50
@github-actions GitHub Actions
Copy link

Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas

@sanketkedia sanketkedia force-pushed the 11-05-spann_segment_impl branch from 1a18963 to f2a594f Compare November 11, 2024 06:02
@sanketkedia sanketkedia force-pushed the 11-06-implement_apply_materialized branch from 99dfd9b to 694681f Compare November 11, 2024 06:02
@github-actions GitHub Actions
Copy link

Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas

@sanketkedia sanketkedia force-pushed the 11-06-implement_apply_materialized branch from 694681f to 1196f5f Compare November 11, 2024 06:22
@github-actions GitHub Actions
Copy link

Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas

1 similar comment
@github-actions GitHub Actions
Copy link

Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas

@sanketkedia sanketkedia force-pushed the 11-05-spann_segment_impl branch from 8e8f005 to 3035ff0 Compare November 11, 2024 06:32
@sanketkedia sanketkedia force-pushed the 11-06-implement_apply_materialized branch from 9cb84a5 to eb86480 Compare November 11, 2024 06:33
@github-actions GitHub Actions
Copy link

Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas

@sanketkedia sanketkedia force-pushed the 11-05-spann_segment_impl branch from 3035ff0 to 182ce43 Compare November 11, 2024 06:43
@sanketkedia sanketkedia force-pushed the 11-06-implement_apply_materialized branch from eb86480 to ec3954d Compare November 11, 2024 06:43
@github-actions GitHub Actions
Copy link

Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas

@sanketkedia sanketkedia force-pushed the 11-05-spann_segment_impl branch from 182ce43 to 8fdc0aa Compare November 11, 2024 07:04
@sanketkedia sanketkedia force-pushed the 11-06-implement_apply_materialized branch from ec3954d to 15357ab Compare November 11, 2024 07:05
@github-actions GitHub Actions
Copy link

Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas

@sanketkedia sanketkedia force-pushed the 11-05-spann_segment_impl branch from 8fdc0aa to d68c041 Compare November 11, 2024 21:44
This was referenced Nov 29, 2024
Merged
Merged
Merged
Merged
@sanketkedia sanketkedia force-pushed the 11-05-spann_segment_impl branch from 955427b to cd33b84 Compare December 3, 2024 18:34
@sanketkedia sanketkedia force-pushed the 11-06-implement_apply_materialized branch from 9744dbf to d04db2f Compare December 3, 2024 18:35
@sanketkedia sanketkedia force-pushed the 11-05-spann_segment_impl branch from cd33b84 to 1c00082 Compare December 4, 2024 17:39
@sanketkedia sanketkedia force-pushed the 11-06-implement_apply_materialized branch 2 times, most recently from 71771cf to 97dcbde Compare December 4, 2024 18:10
@sanketkedia sanketkedia changed the base branch from 11-05-spann_segment_impl to graphite-base/3084 December 4, 2024 19:13
@sanketkedia sanketkedia force-pushed the 11-06-implement_apply_materialized branch from 97dcbde to dc505fe Compare December 4, 2024 19:14
@sanketkedia sanketkedia changed the base branch from graphite-base/3084 to main December 4, 2024 19:14
@sanketkedia sanketkedia force-pushed the 11-06-implement_apply_materialized branch from dc505fe to fc6a644 Compare December 4, 2024 19:14
@sanketkedia Graphite App
Copy link
Contributor Author

sanketkedia commented Dec 4, 2024 •
edited
Loading

Merge activity

  • Dec 4, 2:24 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 4, 2:24 PM EST: A user merged this pull request with Graphite.

@sanketkedia sanketkedia merged commit 0df312a into main Dec 4, 2024
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HammadB HammadB HammadB left review comments

@rescrv rescrv rescrv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sanketkedia @rescrv @HammadB