Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] spann query orchestrator #3219

Merged
merged 3 commits into from
Dec 6, 2024
Merged

Conversation

sanketkedia
Copy link
Contributor

@sanketkedia sanketkedia commented Dec 2, 2024

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • None
  • New functionality
    • New query orchestrator with desired pipelining.

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

None

Copy link

github-actions bot commented Dec 2, 2024

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Copy link

github-actions bot commented Dec 2, 2024

Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas

@sanketkedia sanketkedia mentioned this pull request Dec 2, 2024
1 task
@sanketkedia sanketkedia changed the title new spann orchestrator [ENH] spann query orchestrator Dec 2, 2024
@sanketkedia sanketkedia requested a review from HammadB December 2, 2024 13:07
@sanketkedia sanketkedia force-pushed the 12-02-spann_merge_operator branch from 0727a6f to 7fe5a5c Compare December 3, 2024 18:35
@sanketkedia sanketkedia force-pushed the 12-02-new_spann_orchestrator branch from 513b77c to 9818da8 Compare December 3, 2024 18:36
@sanketkedia sanketkedia force-pushed the 12-02-spann_merge_operator branch from 7fe5a5c to 65e484a Compare December 3, 2024 19:07
@sanketkedia sanketkedia force-pushed the 12-02-new_spann_orchestrator branch from 9818da8 to ec3ab46 Compare December 3, 2024 19:07
@sanketkedia sanketkedia force-pushed the 12-02-spann_merge_operator branch from 65e484a to 4d2d976 Compare December 4, 2024 09:57
@sanketkedia sanketkedia force-pushed the 12-02-new_spann_orchestrator branch from ec3ab46 to 4edd042 Compare December 4, 2024 09:57
@sanketkedia sanketkedia force-pushed the 12-02-spann_merge_operator branch from 4d2d976 to d11be0b Compare December 4, 2024 17:21
@sanketkedia sanketkedia force-pushed the 12-02-new_spann_orchestrator branch from 4edd042 to f57e909 Compare December 4, 2024 17:21
@sanketkedia sanketkedia force-pushed the 12-02-spann_merge_operator branch from d11be0b to 38a7bb7 Compare December 4, 2024 17:40
@sanketkedia sanketkedia force-pushed the 12-02-new_spann_orchestrator branch from f57e909 to 167f30d Compare December 4, 2024 17:40
@sanketkedia sanketkedia force-pushed the 12-02-spann_merge_operator branch from 38a7bb7 to 25b9f28 Compare December 4, 2024 18:11
@sanketkedia sanketkedia force-pushed the 12-02-new_spann_orchestrator branch from 96d1985 to 9e52842 Compare December 5, 2024 16:16
@sanketkedia sanketkedia marked this pull request as ready for review December 5, 2024 16:17
@sanketkedia sanketkedia force-pushed the 12-02-spann_merge_operator branch from 9e9283a to 9e04b68 Compare December 5, 2024 19:33
@sanketkedia sanketkedia force-pushed the 12-02-new_spann_orchestrator branch from 9e52842 to f86ca53 Compare December 5, 2024 19:33
@sanketkedia sanketkedia force-pushed the 12-02-spann_merge_operator branch from 9e04b68 to 0fdd95a Compare December 5, 2024 20:07
@sanketkedia sanketkedia force-pushed the 12-02-new_spann_orchestrator branch from f86ca53 to 44f6506 Compare December 5, 2024 20:07
@sanketkedia sanketkedia force-pushed the 12-02-spann_merge_operator branch from 0fdd95a to 186ebed Compare December 5, 2024 20:48
@sanketkedia sanketkedia force-pushed the 12-02-new_spann_orchestrator branch from 44f6506 to b64f9c4 Compare December 5, 2024 20:48
@sanketkedia sanketkedia force-pushed the 12-02-spann_merge_operator branch from 186ebed to a1c170e Compare December 5, 2024 22:43
@sanketkedia sanketkedia force-pushed the 12-02-new_spann_orchestrator branch from b64f9c4 to e1021c9 Compare December 5, 2024 22:44
@sanketkedia sanketkedia force-pushed the 12-02-spann_merge_operator branch from a1c170e to 3e0fec7 Compare December 5, 2024 22:52
@sanketkedia sanketkedia force-pushed the 12-02-new_spann_orchestrator branch from e1021c9 to 28e94fd Compare December 5, 2024 22:53
@sanketkedia sanketkedia force-pushed the 12-02-spann_merge_operator branch from 3e0fec7 to adb8096 Compare December 5, 2024 22:55
@sanketkedia sanketkedia force-pushed the 12-02-new_spann_orchestrator branch from 28e94fd to b327564 Compare December 5, 2024 22:56
@sanketkedia sanketkedia force-pushed the 12-02-spann_merge_operator branch from adb8096 to 0be8b82 Compare December 5, 2024 23:45
@sanketkedia sanketkedia force-pushed the 12-02-new_spann_orchestrator branch from b327564 to a278a16 Compare December 5, 2024 23:45
@sanketkedia sanketkedia force-pushed the 12-02-spann_merge_operator branch 2 times, most recently from e4d6011 to 8eca47b Compare December 5, 2024 23:48
@sanketkedia sanketkedia force-pushed the 12-02-new_spann_orchestrator branch from a278a16 to 32530d7 Compare December 5, 2024 23:49
@sanketkedia sanketkedia changed the base branch from 12-02-spann_merge_operator to graphite-base/3219 December 5, 2024 23:51
@sanketkedia sanketkedia force-pushed the 12-02-new_spann_orchestrator branch from 32530d7 to 22f93f0 Compare December 5, 2024 23:51
@sanketkedia sanketkedia changed the base branch from graphite-base/3219 to main December 5, 2024 23:52
@sanketkedia sanketkedia force-pushed the 12-02-new_spann_orchestrator branch from 22f93f0 to a8f6124 Compare December 5, 2024 23:52
@sanketkedia sanketkedia force-pushed the 12-02-new_spann_orchestrator branch from a8f6124 to 5589aff Compare December 5, 2024 23:56
Copy link
Contributor Author

sanketkedia commented Dec 6, 2024

Merge activity

  • Dec 5, 7:30 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 5, 7:31 PM EST: A user merged this pull request with Graphite.

@sanketkedia sanketkedia merged commit 6eae5c7 into main Dec 6, 2024
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant