Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] rng_query_operator #3213

Merged
merged 2 commits into from
Dec 5, 2024
Merged

[ENH] rng_query_operator #3213

merged 2 commits into from
Dec 5, 2024

Conversation

sanketkedia
Copy link
Contributor

@sanketkedia sanketkedia commented Nov 29, 2024

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Operator for querying nearest heads for a query
  • New functionality
    • ...

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

None

@sanketkedia sanketkedia changed the title rng_query_operator [ENH] rng_query_operator Nov 29, 2024
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Copy link

Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas

@sanketkedia sanketkedia requested a review from HammadB November 29, 2024 06:53
@sanketkedia sanketkedia marked this pull request as ready for review November 29, 2024 06:53
@sanketkedia sanketkedia force-pushed the 11-27-introduce_spann_segment_reader branch from 9de114c to 95d8dc1 Compare December 3, 2024 18:35
@sanketkedia sanketkedia force-pushed the 11-28-rng_query_operator branch from d1eec30 to 05ec750 Compare December 3, 2024 18:35
@sanketkedia sanketkedia force-pushed the 11-27-introduce_spann_segment_reader branch from 95d8dc1 to 363962b Compare December 3, 2024 19:06
@sanketkedia sanketkedia force-pushed the 11-28-rng_query_operator branch from 05ec750 to 35ba95e Compare December 3, 2024 19:06
@sanketkedia sanketkedia force-pushed the 11-27-introduce_spann_segment_reader branch from 363962b to 0044471 Compare December 4, 2024 09:56
@sanketkedia sanketkedia force-pushed the 11-28-rng_query_operator branch from 35ba95e to e5a9f93 Compare December 4, 2024 09:56
@sanketkedia sanketkedia force-pushed the 11-27-introduce_spann_segment_reader branch from 0044471 to dba56e1 Compare December 4, 2024 17:20
@sanketkedia sanketkedia force-pushed the 11-28-rng_query_operator branch from e5a9f93 to 7e42c35 Compare December 4, 2024 17:20
@sanketkedia sanketkedia force-pushed the 11-27-introduce_spann_segment_reader branch from fb3d737 to 2656f3d Compare December 4, 2024 19:17
@sanketkedia sanketkedia force-pushed the 11-28-rng_query_operator branch from 03d462d to 10aef12 Compare December 4, 2024 19:17
@sanketkedia sanketkedia force-pushed the 11-27-introduce_spann_segment_reader branch from 2656f3d to ed569bd Compare December 4, 2024 19:27
@sanketkedia sanketkedia force-pushed the 11-28-rng_query_operator branch from 10aef12 to 5e9df55 Compare December 4, 2024 19:28
@sanketkedia sanketkedia force-pushed the 11-27-introduce_spann_segment_reader branch from ed569bd to 0172998 Compare December 5, 2024 08:54
@sanketkedia sanketkedia force-pushed the 11-28-rng_query_operator branch from 5e9df55 to 97e7c6a Compare December 5, 2024 08:54
@sanketkedia sanketkedia force-pushed the 11-27-introduce_spann_segment_reader branch from 0172998 to 9b3271e Compare December 5, 2024 09:27
@sanketkedia sanketkedia force-pushed the 11-28-rng_query_operator branch from 97e7c6a to 58e706e Compare December 5, 2024 09:27
@sanketkedia sanketkedia force-pushed the 11-27-introduce_spann_segment_reader branch from 9b3271e to 4b14caa Compare December 5, 2024 09:40
@sanketkedia sanketkedia force-pushed the 11-28-rng_query_operator branch from 58e706e to 5934de4 Compare December 5, 2024 09:40
@sanketkedia sanketkedia force-pushed the 11-27-introduce_spann_segment_reader branch from 4b14caa to 8336900 Compare December 5, 2024 09:45
@sanketkedia sanketkedia force-pushed the 11-28-rng_query_operator branch from 5934de4 to 1554d8d Compare December 5, 2024 09:45
@sanketkedia sanketkedia force-pushed the 11-27-introduce_spann_segment_reader branch from 8336900 to fa4d982 Compare December 5, 2024 10:18
@sanketkedia sanketkedia force-pushed the 11-28-rng_query_operator branch from 1554d8d to a29a59e Compare December 5, 2024 10:18
@sanketkedia sanketkedia force-pushed the 11-27-introduce_spann_segment_reader branch from fa4d982 to 55b5861 Compare December 5, 2024 10:25
@sanketkedia sanketkedia force-pushed the 11-28-rng_query_operator branch from a29a59e to 06c6c56 Compare December 5, 2024 10:26
@sanketkedia sanketkedia force-pushed the 11-27-introduce_spann_segment_reader branch 2 times, most recently from 239186d to cebed64 Compare December 5, 2024 16:08
@sanketkedia sanketkedia force-pushed the 11-28-rng_query_operator branch 3 times, most recently from 292e48e to 61e5f3d Compare December 5, 2024 19:32
@sanketkedia sanketkedia changed the base branch from 11-27-introduce_spann_segment_reader to graphite-base/3213 December 5, 2024 20:05
@sanketkedia sanketkedia force-pushed the 11-28-rng_query_operator branch from 61e5f3d to e6b3412 Compare December 5, 2024 20:05
@sanketkedia sanketkedia changed the base branch from graphite-base/3213 to main December 5, 2024 20:06
@sanketkedia sanketkedia force-pushed the 11-28-rng_query_operator branch from e6b3412 to 7ff7d0a Compare December 5, 2024 20:06
Copy link
Contributor Author

sanketkedia commented Dec 5, 2024

Merge activity

  • Dec 5, 5:54 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 5, 5:54 PM EST: A user merged this pull request with Graphite.

@sanketkedia sanketkedia merged commit c8aa427 into main Dec 5, 2024
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants