Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Fetch posting list operator #3214

Merged
merged 4 commits into from
Dec 5, 2024

Conversation

sanketkedia
Copy link
Contributor

@sanketkedia sanketkedia commented Nov 29, 2024

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Operator for fetching the posting list for a given head. Currently clones the posting list. Can revisit in future if it ends up becoming a performance bottleneck.
  • New functionality
    • ...

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

None

@sanketkedia sanketkedia mentioned this pull request Nov 29, 2024
1 task
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Copy link

Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas

@sanketkedia sanketkedia changed the title Fetch posting list operator [ENH] Fetch posting list operator Nov 29, 2024
@sanketkedia sanketkedia requested a review from HammadB November 29, 2024 06:56
@sanketkedia sanketkedia marked this pull request as ready for review November 29, 2024 06:56
@sanketkedia sanketkedia force-pushed the 11-28-rng_query_operator branch from d1eec30 to 05ec750 Compare December 3, 2024 18:35
@sanketkedia sanketkedia force-pushed the 11-29-fetch_posting_list_operator branch from c0a706e to c379f65 Compare December 3, 2024 18:35
@sanketkedia sanketkedia force-pushed the 11-28-rng_query_operator branch from 05ec750 to 35ba95e Compare December 3, 2024 19:06
@sanketkedia sanketkedia force-pushed the 11-29-fetch_posting_list_operator branch from c379f65 to 9a34ac5 Compare December 3, 2024 19:07
@sanketkedia sanketkedia force-pushed the 11-28-rng_query_operator branch from 35ba95e to e5a9f93 Compare December 4, 2024 09:56
@sanketkedia sanketkedia force-pushed the 11-29-fetch_posting_list_operator branch from 9a34ac5 to 0af2979 Compare December 4, 2024 09:56
@sanketkedia sanketkedia force-pushed the 11-29-fetch_posting_list_operator branch from 0e0806d to 3503841 Compare December 5, 2024 09:27
@sanketkedia sanketkedia force-pushed the 11-28-rng_query_operator branch from 58e706e to 5934de4 Compare December 5, 2024 09:40
@sanketkedia sanketkedia force-pushed the 11-29-fetch_posting_list_operator branch from 3503841 to 2d0070d Compare December 5, 2024 09:40
@sanketkedia sanketkedia force-pushed the 11-28-rng_query_operator branch from 5934de4 to 1554d8d Compare December 5, 2024 09:45
@sanketkedia sanketkedia force-pushed the 11-29-fetch_posting_list_operator branch from 2d0070d to 429b0b9 Compare December 5, 2024 09:46
@sanketkedia sanketkedia force-pushed the 11-28-rng_query_operator branch from 1554d8d to a29a59e Compare December 5, 2024 10:18
@sanketkedia sanketkedia force-pushed the 11-29-fetch_posting_list_operator branch from 429b0b9 to 71b6381 Compare December 5, 2024 10:19
@sanketkedia sanketkedia force-pushed the 11-28-rng_query_operator branch from a29a59e to 06c6c56 Compare December 5, 2024 10:26
@sanketkedia sanketkedia force-pushed the 11-29-fetch_posting_list_operator branch from 71b6381 to 123deff Compare December 5, 2024 10:26
@sanketkedia sanketkedia force-pushed the 11-28-rng_query_operator branch from 06c6c56 to ce159ce Compare December 5, 2024 16:08
@sanketkedia sanketkedia force-pushed the 11-29-fetch_posting_list_operator branch from 123deff to 273b095 Compare December 5, 2024 16:08
@sanketkedia sanketkedia force-pushed the 11-28-rng_query_operator branch from ce159ce to 292e48e Compare December 5, 2024 16:16
@sanketkedia sanketkedia force-pushed the 11-29-fetch_posting_list_operator branch from 273b095 to b9d03b5 Compare December 5, 2024 16:16
@sanketkedia sanketkedia force-pushed the 11-28-rng_query_operator branch from 292e48e to 61e5f3d Compare December 5, 2024 19:32
@sanketkedia sanketkedia force-pushed the 11-29-fetch_posting_list_operator branch from b9d03b5 to b19ef7a Compare December 5, 2024 19:33
@sanketkedia sanketkedia force-pushed the 11-28-rng_query_operator branch 2 times, most recently from e6b3412 to 7ff7d0a Compare December 5, 2024 20:06
@sanketkedia sanketkedia force-pushed the 11-29-fetch_posting_list_operator branch 2 times, most recently from fe398e8 to 14019e7 Compare December 5, 2024 20:48
@sanketkedia sanketkedia changed the base branch from 11-28-rng_query_operator to graphite-base/3214 December 5, 2024 22:54
@sanketkedia sanketkedia force-pushed the 11-29-fetch_posting_list_operator branch from d14c756 to 272cf49 Compare December 5, 2024 22:54
@sanketkedia sanketkedia changed the base branch from graphite-base/3214 to main December 5, 2024 22:55
@sanketkedia sanketkedia force-pushed the 11-29-fetch_posting_list_operator branch from 272cf49 to 371dce3 Compare December 5, 2024 22:55
Copy link
Contributor Author

sanketkedia commented Dec 5, 2024

Merge activity

  • Dec 5, 6:41 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 5, 6:42 PM EST: A user merged this pull request with Graphite.

@sanketkedia sanketkedia merged commit 37a6103 into main Dec 5, 2024
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants