Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Brute force distances for a posting list operator #3215

Merged
merged 3 commits into from
Dec 5, 2024
Merged

[ENH] Brute force distances for a posting list operator #3215

merged 3 commits into from
Dec 5, 2024
+89 −0

Conversation

sanketkedia
Copy link
Contributor

@sanketkedia sanketkedia commented Nov 30, 2024 •
edited
Loading

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • None
  • New functionality
    • Goes over the posting list, filters out the allowed set, sorts and returns the top k.

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

None

@sanketkedia sanketkedia mentioned this pull request Nov 30, 2024
Merged
1 task
@github-actions GitHub Actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@github-actions GitHub Actions
Copy link

Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas

This was referenced Nov 30, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@sanketkedia Graphite App
Copy link
Contributor Author

sanketkedia commented Nov 30, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sanketkedia sanketkedia mentioned this pull request Nov 30, 2024
Merged
1 task
@sanketkedia sanketkedia changed the title brute_force_posting_list_operator [ENH] Brute force distances for a posting list operator Nov 30, 2024
@sanketkedia sanketkedia requested a review from HammadB November 30, 2024 06:56
@sanketkedia sanketkedia marked this pull request as ready for review November 30, 2024 06:56
This was referenced Dec 2, 2024
Merged
Merged
@sanketkedia sanketkedia force-pushed the 11-29-fetch_posting_list_operator branch from c0a706e to c379f65 Compare December 3, 2024 18:35
@sanketkedia sanketkedia force-pushed the 11-29-brute_force_posting_list_operator branch from 17ac675 to 87c76c8 Compare December 3, 2024 18:35
@sanketkedia sanketkedia force-pushed the 11-29-fetch_posting_list_operator branch from c379f65 to 9a34ac5 Compare December 3, 2024 19:07
@sanketkedia sanketkedia force-pushed the 11-29-brute_force_posting_list_operator branch from 87c76c8 to ac63c65 Compare December 3, 2024 19:07
@sanketkedia sanketkedia force-pushed the 11-29-fetch_posting_list_operator branch from 9a34ac5 to 0af2979 Compare December 4, 2024 09:56
@sanketkedia sanketkedia force-pushed the 11-29-brute_force_posting_list_operator branch from ac63c65 to 9628358 Compare December 4, 2024 09:57
@sanketkedia sanketkedia force-pushed the 11-29-fetch_posting_list_operator branch from 0af2979 to f01c366 Compare December 4, 2024 17:20
@sanketkedia sanketkedia force-pushed the 11-29-brute_force_posting_list_operator branch from 9628358 to 436fab6 Compare December 4, 2024 17:21
@sanketkedia sanketkedia force-pushed the 11-29-fetch_posting_list_operator branch from 2d0070d to 429b0b9 Compare December 5, 2024 09:46
@sanketkedia sanketkedia force-pushed the 11-29-brute_force_posting_list_operator branch from 6642b09 to 6f27b36 Compare December 5, 2024 09:46
@sanketkedia sanketkedia force-pushed the 11-29-fetch_posting_list_operator branch from 429b0b9 to 71b6381 Compare December 5, 2024 10:19
@sanketkedia sanketkedia force-pushed the 11-29-brute_force_posting_list_operator branch from 6f27b36 to 2d1607a Compare December 5, 2024 10:19
@sanketkedia sanketkedia force-pushed the 11-29-fetch_posting_list_operator branch from 71b6381 to 123deff Compare December 5, 2024 10:26
@sanketkedia sanketkedia force-pushed the 11-29-brute_force_posting_list_operator branch from 2d1607a to 6a88b0e Compare December 5, 2024 10:27
@sanketkedia sanketkedia force-pushed the 11-29-fetch_posting_list_operator branch from 123deff to 273b095 Compare December 5, 2024 16:08
@sanketkedia sanketkedia force-pushed the 11-29-brute_force_posting_list_operator branch from 6a88b0e to 6f3df6c Compare December 5, 2024 16:09
@sanketkedia sanketkedia force-pushed the 11-29-fetch_posting_list_operator branch from 273b095 to b9d03b5 Compare December 5, 2024 16:16
@sanketkedia sanketkedia force-pushed the 11-29-brute_force_posting_list_operator branch from 6f3df6c to 549922e Compare December 5, 2024 16:16
@sanketkedia sanketkedia force-pushed the 11-29-fetch_posting_list_operator branch from b9d03b5 to b19ef7a Compare December 5, 2024 19:33
@sanketkedia sanketkedia force-pushed the 11-29-brute_force_posting_list_operator branch from 549922e to 2ef59b6 Compare December 5, 2024 19:33
@sanketkedia sanketkedia force-pushed the 11-29-fetch_posting_list_operator branch from b19ef7a to fe398e8 Compare December 5, 2024 20:06
@sanketkedia sanketkedia force-pushed the 11-29-brute_force_posting_list_operator branch from 2ef59b6 to 61a4ac9 Compare December 5, 2024 20:06
@sanketkedia sanketkedia force-pushed the 11-29-fetch_posting_list_operator branch from fe398e8 to 14019e7 Compare December 5, 2024 20:48
@sanketkedia sanketkedia force-pushed the 11-29-brute_force_posting_list_operator branch 2 times, most recently from 3c80fb6 to b6bc664 Compare December 5, 2024 22:43
@sanketkedia sanketkedia force-pushed the 11-29-fetch_posting_list_operator branch 2 times, most recently from 272cf49 to 371dce3 Compare December 5, 2024 22:55
@sanketkedia sanketkedia force-pushed the 11-29-brute_force_posting_list_operator branch from ec2c218 to 3458cb5 Compare December 5, 2024 22:55
@sanketkedia sanketkedia changed the base branch from 11-29-fetch_posting_list_operator to graphite-base/3215 December 5, 2024 23:42
@sanketkedia sanketkedia force-pushed the 11-29-brute_force_posting_list_operator branch from 3458cb5 to 57ac89d Compare December 5, 2024 23:44
@sanketkedia sanketkedia changed the base branch from graphite-base/3215 to main December 5, 2024 23:45
@sanketkedia sanketkedia force-pushed the 11-29-brute_force_posting_list_operator branch from 57ac89d to c178ed7 Compare December 5, 2024 23:45
@sanketkedia Graphite App
Copy link
Contributor Author

sanketkedia commented Dec 5, 2024 •
edited
Loading

Merge activity

  • Dec 5, 6:47 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 5, 6:48 PM EST: A user merged this pull request with Graphite.

@sanketkedia sanketkedia merged commit 46acfc3 into main Dec 5, 2024
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HammadB HammadB HammadB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sanketkedia @HammadB