Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] spann_merge_operator #3218

Merged
merged 2 commits into from
Dec 5, 2024
Merged

[ENH] spann_merge_operator #3218

merged 2 commits into from
Dec 5, 2024

Conversation

sanketkedia
Copy link
Contributor

@sanketkedia sanketkedia commented Dec 2, 2024 •
edited
Loading

Description of changes

Summarize the changes made by this PR.

  • New functionality
    • Implements merge amongst all the parallel posting lists and the log.

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

None

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024

Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas

This was referenced Dec 2, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@sanketkedia Graphite App
Copy link
Contributor Author

sanketkedia commented Dec 2, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Dec 2, 2024
Merged
Merged
@sanketkedia sanketkedia changed the title spann_merge_operator [ENH] spann_merge_operator Dec 2, 2024
@sanketkedia sanketkedia requested a review from HammadB December 2, 2024 13:05
@sanketkedia sanketkedia marked this pull request as ready for review December 2, 2024 13:06
@sanketkedia sanketkedia force-pushed the 11-29-brute_force_posting_list_operator branch from 17ac675 to 87c76c8 Compare December 3, 2024 18:35
@sanketkedia sanketkedia force-pushed the 12-02-spann_merge_operator branch from 0727a6f to 7fe5a5c Compare December 3, 2024 18:35
@sanketkedia sanketkedia force-pushed the 11-29-brute_force_posting_list_operator branch from 87c76c8 to ac63c65 Compare December 3, 2024 19:07
@sanketkedia sanketkedia force-pushed the 12-02-spann_merge_operator branch from 7fe5a5c to 65e484a Compare December 3, 2024 19:07
@sanketkedia sanketkedia force-pushed the 11-29-brute_force_posting_list_operator branch from ac63c65 to 9628358 Compare December 4, 2024 09:57
@sanketkedia sanketkedia force-pushed the 12-02-spann_merge_operator branch from 65e484a to 4d2d976 Compare December 4, 2024 09:57
@sanketkedia sanketkedia force-pushed the 11-29-brute_force_posting_list_operator branch from 9628358 to 436fab6 Compare December 4, 2024 17:21
@sanketkedia sanketkedia force-pushed the 12-02-spann_merge_operator branch from 4d2d976 to d11be0b Compare December 4, 2024 17:21
@sanketkedia sanketkedia force-pushed the 11-29-brute_force_posting_list_operator branch from 436fab6 to 4ada9cb Compare December 4, 2024 17:40
@sanketkedia sanketkedia force-pushed the 12-02-spann_merge_operator branch from e347568 to ba5d4ca Compare December 5, 2024 10:20
@sanketkedia sanketkedia force-pushed the 11-29-brute_force_posting_list_operator branch from 2d1607a to 6a88b0e Compare December 5, 2024 10:27
@sanketkedia sanketkedia force-pushed the 12-02-spann_merge_operator branch from ba5d4ca to 790c09a Compare December 5, 2024 10:28
@sanketkedia sanketkedia force-pushed the 11-29-brute_force_posting_list_operator branch from 6a88b0e to 6f3df6c Compare December 5, 2024 16:09
@sanketkedia sanketkedia force-pushed the 12-02-spann_merge_operator branch from 790c09a to 4184323 Compare December 5, 2024 16:10
@sanketkedia sanketkedia force-pushed the 11-29-brute_force_posting_list_operator branch from 6f3df6c to 549922e Compare December 5, 2024 16:16
@sanketkedia sanketkedia force-pushed the 12-02-spann_merge_operator branch from 4184323 to 9e9283a Compare December 5, 2024 16:16
@sanketkedia sanketkedia force-pushed the 11-29-brute_force_posting_list_operator branch from 549922e to 2ef59b6 Compare December 5, 2024 19:33
@sanketkedia sanketkedia force-pushed the 12-02-spann_merge_operator branch from 9e9283a to 9e04b68 Compare December 5, 2024 19:33
@sanketkedia sanketkedia force-pushed the 11-29-brute_force_posting_list_operator branch from 2ef59b6 to 61a4ac9 Compare December 5, 2024 20:06
@sanketkedia sanketkedia force-pushed the 12-02-spann_merge_operator branch from 9e04b68 to 0fdd95a Compare December 5, 2024 20:07
@sanketkedia sanketkedia force-pushed the 11-29-brute_force_posting_list_operator branch from 61a4ac9 to 3c80fb6 Compare December 5, 2024 20:48
@sanketkedia sanketkedia force-pushed the 12-02-spann_merge_operator branch from 0fdd95a to 186ebed Compare December 5, 2024 20:48
@sanketkedia sanketkedia force-pushed the 11-29-brute_force_posting_list_operator branch from 3c80fb6 to b6bc664 Compare December 5, 2024 22:43
@sanketkedia sanketkedia force-pushed the 12-02-spann_merge_operator branch 2 times, most recently from a1c170e to 3e0fec7 Compare December 5, 2024 22:52
@sanketkedia sanketkedia force-pushed the 11-29-brute_force_posting_list_operator branch from ec2c218 to 3458cb5 Compare December 5, 2024 22:55
@sanketkedia sanketkedia force-pushed the 12-02-spann_merge_operator branch from 3e0fec7 to adb8096 Compare December 5, 2024 22:55
@sanketkedia sanketkedia force-pushed the 11-29-brute_force_posting_list_operator branch 2 times, most recently from 57ac89d to c178ed7 Compare December 5, 2024 23:45
@sanketkedia sanketkedia force-pushed the 12-02-spann_merge_operator branch from adb8096 to 0be8b82 Compare December 5, 2024 23:45
@sanketkedia sanketkedia changed the base branch from 11-29-brute_force_posting_list_operator to graphite-base/3218 December 5, 2024 23:48
@sanketkedia sanketkedia force-pushed the 12-02-spann_merge_operator branch from 0be8b82 to e4d6011 Compare December 5, 2024 23:48
@sanketkedia sanketkedia changed the base branch from graphite-base/3218 to main December 5, 2024 23:48
@sanketkedia sanketkedia force-pushed the 12-02-spann_merge_operator branch from e4d6011 to 8eca47b Compare December 5, 2024 23:48
@sanketkedia Graphite App
Copy link
Contributor Author

sanketkedia commented Dec 5, 2024 •
edited
Loading

Merge activity

  • Dec 5, 6:51 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 5, 6:51 PM EST: A user merged this pull request with Graphite.

@sanketkedia sanketkedia merged commit 1bac16a into main Dec 5, 2024
69 of 70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HammadB HammadB HammadB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sanketkedia @HammadB