Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Introduce spann segment and index #3080

Merged
merged 10 commits into from
Dec 4, 2024
Merged

Conversation

sanketkedia
Copy link
Contributor

@sanketkedia sanketkedia commented Nov 6, 2024

Description of changes

  • New functionality
    • Added SPANN index and segment writer types
    • Added from_segment() impl

Test plan

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

None

Copy link

github-actions bot commented Nov 6, 2024

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Copy link

github-actions bot commented Nov 6, 2024

Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas

@sanketkedia sanketkedia changed the title Spann_segment_impl [ENH] Introduce spann segment and index Nov 6, 2024
@sanketkedia sanketkedia requested a review from HammadB November 6, 2024 19:01
@sanketkedia sanketkedia marked this pull request as ready for review November 6, 2024 19:01
@sanketkedia sanketkedia force-pushed the 10-31-cleanup_hnsw_provider_to_not_know_about_segments branch from 00c5f8c to f0ad6a4 Compare November 11, 2024 02:50
@sanketkedia sanketkedia force-pushed the 11-05-spann_segment_impl branch 2 times, most recently from 1a18963 to f2a594f Compare November 11, 2024 06:02
@sanketkedia sanketkedia force-pushed the 10-31-cleanup_hnsw_provider_to_not_know_about_segments branch from d2a9c0c to 175edc0 Compare November 11, 2024 06:32
@sanketkedia sanketkedia force-pushed the 11-05-spann_segment_impl branch from 8e8f005 to 3035ff0 Compare November 11, 2024 06:32
@sanketkedia sanketkedia force-pushed the 10-31-cleanup_hnsw_provider_to_not_know_about_segments branch from 175edc0 to 2d374da Compare November 11, 2024 06:43
@sanketkedia sanketkedia force-pushed the 11-05-spann_segment_impl branch 3 times, most recently from 8fdc0aa to d68c041 Compare November 11, 2024 21:44
@sanketkedia sanketkedia force-pushed the 10-31-cleanup_hnsw_provider_to_not_know_about_segments branch from 0d5190c to cd1753d Compare November 13, 2024 21:25
@sanketkedia sanketkedia force-pushed the 11-05-spann_segment_impl branch from d68c041 to db9f8cb Compare November 13, 2024 21:25
@sanketkedia sanketkedia force-pushed the 10-31-cleanup_hnsw_provider_to_not_know_about_segments branch from cd1753d to 8ecadb4 Compare November 13, 2024 21:28
@sanketkedia sanketkedia force-pushed the 11-05-spann_segment_impl branch from db9f8cb to 9ab8f5c Compare November 13, 2024 21:28
@sanketkedia sanketkedia force-pushed the 10-31-cleanup_hnsw_provider_to_not_know_about_segments branch from 8ecadb4 to 64f6165 Compare November 13, 2024 22:11
@sanketkedia sanketkedia force-pushed the 11-05-spann_segment_impl branch from 9ab8f5c to 8803f61 Compare November 13, 2024 22:11
@sanketkedia sanketkedia force-pushed the 10-31-cleanup_hnsw_provider_to_not_know_about_segments branch 2 times, most recently from 4a4d501 to 12db19e Compare November 13, 2024 22:15
@sanketkedia sanketkedia force-pushed the 11-05-spann_segment_impl branch from 8803f61 to 54df1fb Compare November 13, 2024 22:15
@sanketkedia sanketkedia force-pushed the 11-05-spann_segment_impl branch from ebd2f37 to 7ba706f Compare November 14, 2024 06:46
@sanketkedia sanketkedia changed the base branch from graphite-base/3080 to main November 14, 2024 06:47
@sanketkedia sanketkedia force-pushed the 11-05-spann_segment_impl branch from 7ba706f to 6fb817e Compare November 14, 2024 06:47
@sanketkedia sanketkedia mentioned this pull request Nov 19, 2024
1 task
@sanketkedia sanketkedia force-pushed the 11-05-spann_segment_impl branch from cd33b84 to 1c00082 Compare December 4, 2024 17:39
Copy link
Contributor Author

sanketkedia commented Dec 4, 2024

Merge activity

  • Dec 4, 2:13 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 4, 2:13 PM EST: A user merged this pull request with Graphite.

@sanketkedia sanketkedia merged commit 435f7d0 into main Dec 4, 2024
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants