Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] implement append, commit and flush for spann segment and index #3084

Merged
merged 14 commits into from
Dec 4, 2024
Merged

[ENH] implement append, commit and flush for spann segment and index #3084

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
183996c
implement apply_materialized
sanketkedia Nov 6, 2024
54a5a7f
Implement append
sanketkedia Nov 9, 2024
63cf60c
Build errors
sanketkedia Nov 11, 2024
1bc6f0d
Linter
sanketkedia Nov 11, 2024
ea7c249
Build errors
sanketkedia Nov 11, 2024
b702cb9
Implement commit and flush
sanketkedia Nov 12, 2024
c13c8b9
Add test
sanketkedia Nov 13, 2024
7f89a63
Make linter happy
sanketkedia Nov 13, 2024
1a75962
Cleanup errors
sanketkedia Nov 13, 2024
4b2b9cc
Fix build
sanketkedia Nov 13, 2024
a6bb23b
Fix build error due to rebase
sanketkedia Nov 13, 2024
c886068
Fix build
sanketkedia Dec 3, 2024
5e097f4
Cleanup + review comments
sanketkedia Dec 4, 2024
fc6a644
Fix rust test
sanketkedia Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions rust/blockstore/src/types/writer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,23 @@ impl BlockfileWriter {
}
}

pub async fn get_owned<
K: Key + Into<KeyWrapper> + ArrowWriteableKey,
V: Value + Writeable + ArrowWriteableValue,
>(
&self,
prefix: &str,
key: K,
) -> Result<Option<V::PreparedValue>, Box<dyn ChromaError>> {
match self {
BlockfileWriter::MemoryBlockfileWriter(_) => todo!(),
BlockfileWriter::ArrowUnorderedBlockfileWriter(writer) => {
writer.get_owned::<K, V>(prefix, key).await
}
BlockfileWriter::ArrowOrderedBlockfileWriter(_) => todo!(),
}
}

pub fn id(&self) -> uuid::Uuid {
match self {
BlockfileWriter::MemoryBlockfileWriter(writer) => writer.id(),
Expand Down
Loading
Loading