Implement append

chroma-core · Nov 9, 2024 · f7b4553 · f7b4553
1 parent 2b3388f
commit f7b4553
Show file tree

Hide file tree

Showing 8 changed files with 325 additions and 34 deletions.
diff --git a/rust/blockstore/src/arrow/types.rs b/rust/blockstore/src/arrow/types.rs
@@ -17,7 +17,7 @@ pub trait ArrowWriteableKey: Key + Default {
     ) -> BlockKeyArrowBuilder;
 }
 
-pub(crate) trait ArrowWriteableValue: Value {
+pub trait ArrowWriteableValue: Value {
     type ReadableValue<'referred_data>: ArrowReadableValue<'referred_data>;
     type OwnedReadableValue;
 

diff --git a/rust/blockstore/src/types.rs b/rust/blockstore/src/types.rs
@@ -194,6 +194,22 @@ impl BlockfileWriter {
         }
     }
 
+    pub async fn get_clone<
+        K: Key + Into<KeyWrapper> + ArrowWriteableKey,
+        V: Value + Writeable + ArrowWriteableValue,
+    >(
+        &self,
+        prefix: &str,
+        key: K,
+    ) -> Result<Option<V::OwnedReadableValue>, Box<dyn ChromaError>> {
+        match self {
+            BlockfileWriter::MemoryBlockfileWriter(_) => todo!(),
+            BlockfileWriter::ArrowBlockfileWriter(writer) => {
+                writer.get_clone::<K, V>(prefix, key).await
+            }
+        }
+    }
+
     pub fn id(&self) -> uuid::Uuid {
         match self {
             BlockfileWriter::MemoryBlockfileWriter(writer) => writer.id(),