Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] connect: Add support for select #3344

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Conversation

andrewgazelka
Copy link
Contributor

No description provided.

@andrewgazelka andrewgazelka marked this pull request as ready for review November 20, 2024 06:19
Copy link
Contributor Author

andrewgazelka commented Nov 20, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@andrewgazelka andrewgazelka changed the base branch from andrew/connect-alias to graphite-base/3344 November 21, 2024 04:13
@andrewgazelka andrewgazelka changed the base branch from graphite-base/3344 to main November 21, 2024 04:14
@github-actions github-actions bot added the enhancement New feature or request label Nov 21, 2024
Copy link

codspeed-hq bot commented Nov 21, 2024

CodSpeed Performance Report

Merging #3344 will degrade performances by 39.66%

Comparing andrew/connect-select (981e2e7) with main (cbe9d3b)

Summary

❌ 1 regressions
✅ 16 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main andrew/connect-select Change
test_show[100 Small Files] 15 ms 24.8 ms -39.66%

Copy link

graphite-app bot commented Nov 21, 2024

Graphite Automations

"Notify author when CI fails" took an action on this PR • (11/21/24)

1 teammate was notified to this PR based on Andrew Gazelka's automation.

tests/connect/test_select.py Show resolved Hide resolved
tests/connect/test_select.py Show resolved Hide resolved
tests/connect/test_select.py Show resolved Hide resolved
tests/connect/test_select.py Show resolved Hide resolved
@andrewgazelka andrewgazelka merged commit e236332 into main Nov 21, 2024
42 of 43 checks passed
Copy link
Contributor Author

Merge activity

  • Nov 21, 1:26 PM EST: A user merged this pull request with Graphite.

@andrewgazelka andrewgazelka deleted the andrew/connect-select branch November 21, 2024 18:26
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.35%. Comparing base (cbe9d3b) to head (981e2e7).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3344   +/-   ##
=======================================
  Coverage   77.35%   77.35%           
=======================================
  Files         685      685           
  Lines       83639    83639           
=======================================
  Hits        64702    64702           
  Misses      18937    18937           

see 1 file with indirect coverage changes

---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants