Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connect): add drop support #3345

Merged
merged 2 commits into from
Dec 11, 2024
Merged

feat(connect): add drop support #3345

merged 2 commits into from
Dec 11, 2024

Conversation

andrewgazelka
Copy link
Contributor

@andrewgazelka andrewgazelka commented Nov 20, 2024

No description provided.

@andrewgazelka andrewgazelka marked this pull request as ready for review November 20, 2024 06:35
Copy link
Contributor Author

andrewgazelka commented Nov 20, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@andrewgazelka andrewgazelka force-pushed the andrew/connect-drop branch 2 times, most recently from 30ec7d4 to 69c91cb Compare November 21, 2024 18:44
@andrewgazelka andrewgazelka changed the title [FEAT] connect: add drop support [FEAT] 🚧🚧🚧 connect: add drop support BLOCKED Nov 27, 2024
@andrewgazelka andrewgazelka marked this pull request as draft November 27, 2024 19:03
@andrewgazelka andrewgazelka force-pushed the andrew/connect-drop branch 4 times, most recently from a69eb97 to 926ee0b Compare December 5, 2024 18:28
@andrewgazelka andrewgazelka changed the title [FEAT] 🚧🚧🚧 connect: add drop support BLOCKED [FEAT] add drop support Dec 5, 2024
@andrewgazelka andrewgazelka force-pushed the andrew/connect-drop branch 6 times, most recently from 9b1eaa0 to e00d722 Compare December 11, 2024 21:11
@andrewgazelka andrewgazelka marked this pull request as ready for review December 11, 2024 21:14
@andrewgazelka andrewgazelka enabled auto-merge (squash) December 11, 2024 21:18
@andrewgazelka andrewgazelka changed the title [FEAT] add drop support feat: add drop support Dec 11, 2024
@andrewgazelka andrewgazelka changed the title feat: add drop support feat(connect): add drop support Dec 11, 2024
@github-actions github-actions bot added the feat label Dec 11, 2024
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 89.65517% with 3 lines in your changes missing coverage. Please review.

Project coverage is 77.78%. Comparing base (5238279) to head (a2b6e59).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../daft-connect/src/translation/logical_plan/drop.rs 92.30% 2 Missing ⚠️
src/daft-connect/src/translation/logical_plan.rs 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3345   +/-   ##
=======================================
  Coverage   77.77%   77.78%           
=======================================
  Files         715      716    +1     
  Lines       87695    87724   +29     
=======================================
+ Hits        68207    68233   +26     
- Misses      19488    19491    +3     
Files with missing lines Coverage Δ
src/daft-connect/src/translation/logical_plan.rs 68.96% <66.66%> (-0.13%) ⬇️
.../daft-connect/src/translation/logical_plan/drop.rs 92.30% <92.30%> (ø)

... and 2 files with indirect coverage changes

Copy link
Contributor Author

Merge activity

  • Dec 11, 4:57 PM EST: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..

@andrewgazelka andrewgazelka merged commit e9777ee into main Dec 11, 2024
43 of 44 checks passed
@andrewgazelka andrewgazelka deleted the andrew/connect-drop branch December 11, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants