-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] connect: add modulus operator and withColumns support #3351
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
7f0c85d
to
81d6894
Compare
b7cdee2
to
7ee8125
Compare
7ee8125
to
0f17b20
Compare
81d6894
to
28e0edf
Compare
0f17b20
to
bc80ee7
Compare
28e0edf
to
b399d76
Compare
bc80ee7
to
128d640
Compare
b399d76
to
0eb7089
Compare
0de1230
to
c466dd5
Compare
0eb7089
to
b09fc18
Compare
c466dd5
to
6483686
Compare
b09fc18
to
0849d25
Compare
6483686
to
6dd398b
Compare
0849d25
to
eb1c9af
Compare
6dd398b
to
553ba66
Compare
eb1c9af
to
4bf4495
Compare
553ba66
to
b6dcec1
Compare
4bf4495
to
548c302
Compare
b6dcec1
to
892ff4f
Compare
548c302
to
632c80c
Compare
892ff4f
to
6663753
Compare
632c80c
to
8ace42d
Compare
eddb120
to
6d4ad74
Compare
28173ab
to
cdca2e2
Compare
6d4ad74
to
6020c6b
Compare
cdca2e2
to
fbc5c6e
Compare
6020c6b
to
f7f7e1e
Compare
fbc5c6e
to
a2e0beb
Compare
f7f7e1e
to
beb40fa
Compare
b9a7f70
to
3ee5757
Compare
42c53df
to
a11e646
Compare
a11e646
to
ffcd80e
Compare
CodSpeed Performance ReportMerging #3351 will degrade performances by 41.02%Comparing Summary
Benchmarks breakdown
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3351 +/- ##
==========================================
+ Coverage 77.28% 77.36% +0.07%
==========================================
Files 699 700 +1
Lines 85240 85274 +34
==========================================
+ Hits 65879 65973 +94
+ Misses 19361 19301 -60
|
ffcd80e
to
4612738
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, probably change the PR messaging though to reflect that we're adding sum
and with_columns
. Looks like groupby itself already works.
4612738
to
0ffb86d
Compare
0ffb86d
to
cfe413b
Compare
cfe413b
to
3d691bb
Compare
%
operator andsum
function to unresolved functions