Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] connect: add binary operators #3350

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

andrewgazelka
Copy link
Member

No description provided.

Copy link
Member Author

andrewgazelka commented Nov 20, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@andrewgazelka andrewgazelka force-pushed the andrew/connect-binary-operators branch from 7f0c85d to 81d6894 Compare November 20, 2024 08:03
@andrewgazelka andrewgazelka force-pushed the andrew/connect-binary-operators branch 2 times, most recently from 28e0edf to b399d76 Compare November 20, 2024 09:45
@andrewgazelka andrewgazelka changed the base branch from andrew/connect-alias to andrew/connect-refactor-to-ref November 20, 2024 09:45
@andrewgazelka andrewgazelka force-pushed the andrew/connect-binary-operators branch from b399d76 to 0eb7089 Compare November 20, 2024 09:52
@andrewgazelka andrewgazelka force-pushed the andrew/connect-binary-operators branch from 0eb7089 to b09fc18 Compare November 20, 2024 11:19
@andrewgazelka andrewgazelka changed the base branch from andrew/connect-refactor-to-ref to andrew/connect-column-operations November 20, 2024 11:19
@andrewgazelka andrewgazelka force-pushed the andrew/connect-column-operations branch from 22d7e93 to 83f2117 Compare November 20, 2024 18:25
@andrewgazelka andrewgazelka force-pushed the andrew/connect-binary-operators branch from b09fc18 to 0849d25 Compare November 20, 2024 18:25
@andrewgazelka andrewgazelka force-pushed the andrew/connect-column-operations branch from 83f2117 to df7ffd5 Compare November 20, 2024 18:32
@andrewgazelka andrewgazelka force-pushed the andrew/connect-binary-operators branch from 0849d25 to eb1c9af Compare November 20, 2024 18:32
@andrewgazelka andrewgazelka force-pushed the andrew/connect-column-operations branch from df7ffd5 to 5c5279f Compare November 20, 2024 18:43
@andrewgazelka andrewgazelka force-pushed the andrew/connect-binary-operators branch from eb1c9af to 4bf4495 Compare November 20, 2024 18:43
@andrewgazelka andrewgazelka force-pushed the andrew/connect-column-operations branch from 5c5279f to ba57801 Compare November 20, 2024 18:48
@andrewgazelka andrewgazelka force-pushed the andrew/connect-binary-operators branch from 4bf4495 to 548c302 Compare November 20, 2024 18:48
@andrewgazelka andrewgazelka force-pushed the andrew/connect-column-operations branch from ba57801 to 81ff3b6 Compare November 20, 2024 19:32
@andrewgazelka andrewgazelka force-pushed the andrew/connect-column-operations branch from 000fc66 to 5bfb232 Compare November 21, 2024 05:15
@andrewgazelka andrewgazelka force-pushed the andrew/connect-binary-operators branch from 3a8c076 to 8f7a067 Compare November 21, 2024 05:15
@andrewgazelka andrewgazelka force-pushed the andrew/connect-column-operations branch from 5bfb232 to f6ff23a Compare November 21, 2024 05:16
@andrewgazelka andrewgazelka force-pushed the andrew/connect-binary-operators branch from 8f7a067 to 54468cc Compare November 21, 2024 05:16
@andrewgazelka andrewgazelka force-pushed the andrew/connect-column-operations branch from f6ff23a to 8cd72b7 Compare November 21, 2024 16:57
@andrewgazelka andrewgazelka force-pushed the andrew/connect-binary-operators branch from 54468cc to 28173ab Compare November 21, 2024 16:57
@andrewgazelka andrewgazelka force-pushed the andrew/connect-column-operations branch from 8cd72b7 to ee7e08b Compare November 21, 2024 18:43
@andrewgazelka andrewgazelka force-pushed the andrew/connect-binary-operators branch from 28173ab to cdca2e2 Compare November 21, 2024 18:43
@andrewgazelka andrewgazelka force-pushed the andrew/connect-column-operations branch 2 times, most recently from ca4d137 to 2c7437d Compare November 27, 2024 07:42
@andrewgazelka andrewgazelka force-pushed the andrew/connect-binary-operators branch from cdca2e2 to fbc5c6e Compare November 27, 2024 07:42
@andrewgazelka andrewgazelka marked this pull request as draft November 27, 2024 21:04
@andrewgazelka andrewgazelka force-pushed the andrew/connect-column-operations branch 3 times, most recently from 67bb5fe to a0165a6 Compare December 4, 2024 02:08
@andrewgazelka andrewgazelka force-pushed the andrew/connect-binary-operators branch from fbc5c6e to a2e0beb Compare December 4, 2024 02:09
@andrewgazelka andrewgazelka changed the base branch from andrew/connect-column-operations to graphite-base/3350 December 4, 2024 02:32
@andrewgazelka andrewgazelka force-pushed the andrew/connect-binary-operators branch from a2e0beb to b9a7f70 Compare December 4, 2024 02:32
@andrewgazelka andrewgazelka changed the base branch from graphite-base/3350 to main December 4, 2024 02:33
@andrewgazelka andrewgazelka force-pushed the andrew/connect-binary-operators branch from b9a7f70 to 3ee5757 Compare December 4, 2024 02:33
@github-actions github-actions bot added the enhancement New feature or request label Dec 4, 2024
Copy link

codspeed-hq bot commented Dec 4, 2024

CodSpeed Performance Report

Merging #3350 will degrade performances by 11.7%

Comparing andrew/connect-binary-operators (3ee5757) with main (caf0626)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 15 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main andrew/connect-binary-operators Change
test_iter_rows_first_row[100 Small Files] 221.4 ms 250.8 ms -11.7%
test_show[100 Small Files] 31.9 ms 25.1 ms +27.16%

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 16 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@caf0626). Learn more about missing BASE report.
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...onnect/src/translation/expr/unresolved_function.rs 20.00% 16 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3350   +/-   ##
=======================================
  Coverage        ?   77.32%           
=======================================
  Files           ?      696           
  Lines           ?    84736           
  Branches        ?        0           
=======================================
  Hits            ?    65521           
  Misses          ?    19215           
  Partials        ?        0           
Files with missing lines Coverage Δ
...onnect/src/translation/expr/unresolved_function.rs 52.11% <20.00%> (ø)

@andrewgazelka andrewgazelka marked this pull request as ready for review December 4, 2024 02:59
@andrewgazelka andrewgazelka merged commit 988ee75 into main Dec 4, 2024
44 of 45 checks passed
@andrewgazelka andrewgazelka deleted the andrew/connect-binary-operators branch December 4, 2024 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants