feat(connect): with_columns_renamed

[andrewgazelka]

No description provided.

[andrewgazelka]

• [FEAT] connect: df.join #3354
• feat(connect): with_columns_renamed #3386 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[graphite-app]

Graphite Automations

"Warn authors when publishing large PRs" took an action on this PR • (11/21/24)

1 teammate was notified to this PR based on Andrew Gazelka's automation.

[codspeed-hq]

CodSpeed Performance Report

Merging #3386 will degrade performances by 42.82%

_{Comparing andrew/connect-with-columns-renamed (ce15fe0) with main (ae74c10)}

Summary

❌ 1 regressions
✅ 26 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

	Benchmark	main	andrew/connect-with-columns-renamed	Change
❌	test_iter_rows_first_row[100 Small Files]	131.6 ms	230.2 ms	-42.82%

[codecov]

Codecov Report

Attention: Patch coverage is 80.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 75.80%. Comparing base (ae74c10) to head (ce15fe0).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
...c/translation/logical_plan/with_columns_renamed.rs	80.76%	5 Missing ⚠️
src/daft-connect/src/translation/logical_plan.rs	75.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3386      +/-   ##
==========================================
- Coverage   77.84%   75.80%   -2.04%     
==========================================
  Files         718      718              
  Lines       88250    91190    +2940     
==========================================
+ Hits        68696    69127     +431     
- Misses      19554    22063    +2509     

Files with missing lines	Coverage Δ
src/daft-connect/src/translation/logical_plan.rs	87.40% <75.00%> (-0.38%)	⬇️
...c/translation/logical_plan/with_columns_renamed.rs	80.76% <80.76%> (ø)

... and 43 files with indirect coverage changes