Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connect): with_columns_renamed #3386

Merged
merged 2 commits into from
Dec 19, 2024

slight restructure

ce15fe0
Select commit
Loading
Failed to load commit list.
Merged

feat(connect): with_columns_renamed #3386

slight restructure
ce15fe0
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Dec 19, 2024 in 0s

75.80% (-2.04%) compared to ae74c10

View this Pull Request on Codecov

75.80% (-2.04%) compared to ae74c10

Details

Codecov Report

Attention: Patch coverage is 80.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 75.80%. Comparing base (ae74c10) to head (ce15fe0).

Files with missing lines Patch % Lines
...c/translation/logical_plan/with_columns_renamed.rs 80.76% 5 Missing ⚠️
src/daft-connect/src/translation/logical_plan.rs 75.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3386      +/-   ##
==========================================
- Coverage   77.84%   75.80%   -2.04%     
==========================================
  Files         718      718              
  Lines       88250    91190    +2940     
==========================================
+ Hits        68696    69127     +431     
- Misses      19554    22063    +2509     
Files with missing lines Coverage Δ
src/daft-connect/src/translation/logical_plan.rs 87.40% <75.00%> (-0.38%) ⬇️
...c/translation/logical_plan/with_columns_renamed.rs 80.76% <80.76%> (ø)

... and 43 files with indirect coverage changes