Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] connect: to_daft_* use ref instead of value #3355

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

andrewgazelka
Copy link
Member

No description provided.

@andrewgazelka andrewgazelka mentioned this pull request Nov 20, 2024
1 task
@andrewgazelka andrewgazelka marked this pull request as ready for review November 20, 2024 09:25
Copy link
Member Author

andrewgazelka commented Nov 20, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@andrewgazelka andrewgazelka force-pushed the andrew/connect-refactor-to-ref branch from 863ac08 to c999ae9 Compare November 20, 2024 18:24
@andrewgazelka andrewgazelka force-pushed the andrew/connect-refactor-to-ref branch from c999ae9 to 394c381 Compare November 20, 2024 18:32
@andrewgazelka andrewgazelka force-pushed the andrew/connect-refactor-to-ref branch from 394c381 to 3fb2d4f Compare November 20, 2024 18:43
@andrewgazelka andrewgazelka force-pushed the andrew/connect-refactor-to-ref branch from 3fb2d4f to 4f49d30 Compare November 20, 2024 18:48
@andrewgazelka andrewgazelka force-pushed the andrew/connect-refactor-to-ref branch from 4f49d30 to e95abbd Compare November 20, 2024 19:32
@andrewgazelka andrewgazelka force-pushed the andrew/connect-refactor-to-ref branch from e95abbd to 0e54699 Compare November 20, 2024 22:12
@andrewgazelka andrewgazelka force-pushed the andrew/connect-refactor-to-ref branch from 0e54699 to cdcd749 Compare November 20, 2024 23:28
@andrewgazelka andrewgazelka force-pushed the andrew/connect-refactor-to-ref branch from cdcd749 to bab72c1 Compare November 21, 2024 00:39
@andrewgazelka andrewgazelka force-pushed the andrew/connect-refactor-to-ref branch from bab72c1 to 376a363 Compare November 21, 2024 01:44
@andrewgazelka andrewgazelka force-pushed the andrew/connect-refactor-to-ref branch from 376a363 to db6a4a7 Compare November 21, 2024 01:49
@andrewgazelka andrewgazelka force-pushed the andrew/connect-refactor-to-ref branch from db6a4a7 to b64d626 Compare November 21, 2024 03:21
@andrewgazelka andrewgazelka changed the base branch from andrew/connect-alias to graphite-base/3355 November 21, 2024 04:13
@andrewgazelka andrewgazelka force-pushed the andrew/connect-refactor-to-ref branch from b64d626 to e18546e Compare November 21, 2024 04:17
@andrewgazelka andrewgazelka changed the base branch from graphite-base/3355 to main November 21, 2024 04:18
@andrewgazelka andrewgazelka force-pushed the andrew/connect-refactor-to-ref branch 2 times, most recently from 2ccceb9 to db3b512 Compare November 21, 2024 04:18
Copy link

codspeed-hq bot commented Nov 21, 2024

CodSpeed Performance Report

Merging #3355 will degrade performances by 12.48%

Comparing andrew/connect-refactor-to-ref (db3b512) with main (88edc4a)

Summary

❌ 1 regressions
✅ 16 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main andrew/connect-refactor-to-ref Change
test_count[1 Small File] 3.4 ms 3.9 ms -12.48%

@andrewgazelka andrewgazelka changed the title [REFACTOR] connect: to_daft_* use ref instead of value [FEAT] connect: to_daft_* use ref instead of value Nov 21, 2024
Copy link

graphite-app bot commented Nov 21, 2024

Graphite Automations

"Notify author when CI fails" took an action on this PR • (11/21/24)

1 teammate was notified to this PR based on Andrew Gazelka's automation.

@github-actions github-actions bot added the enhancement New feature or request label Nov 21, 2024
@andrewgazelka andrewgazelka merged commit 3394a66 into main Nov 21, 2024
44 of 47 checks passed
Copy link
Member Author

Merge activity

  • Nov 21, 12:11 AM EST: A user merged this pull request with Graphite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants