Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] connect: to_daft_* use ref instead of value #3355

Merged
merged 1 commit into from
Nov 21, 2024

[REFACTOR] connect: `to_daft_*` use ref instead of value

db3b512
Select commit
Loading
Failed to load commit list.
Merged

[FEAT] connect: to_daft_* use ref instead of value #3355

[REFACTOR] connect: `to_daft_*` use ref instead of value
db3b512
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 21, 2024 in 0s

77.35% (+0.00%) compared to 88edc4a

View this Pull Request on Codecov

77.35% (+0.00%) compared to 88edc4a

Details

Codecov Report

Attention: Patch coverage is 28.00000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 77.35%. Comparing base (88edc4a) to head (db3b512).

Files with missing lines Patch % Lines
src/daft-connect/src/translation/literal.rs 0.00% 12 Missing ⚠️
...onnect/src/translation/expr/unresolved_function.rs 0.00% 4 Missing ⚠️
...-connect/src/translation/logical_plan/aggregate.rs 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3355   +/-   ##
=======================================
  Coverage   77.35%   77.35%           
=======================================
  Files         685      685           
  Lines       83629    83629           
=======================================
  Hits        64689    64689           
  Misses      18940    18940
Files with missing lines Coverage Δ
src/daft-connect/src/translation/expr.rs 54.38% <100.00%> (ø)
...ft-connect/src/translation/logical_plan/project.rs 88.88% <100.00%> (ø)
...-connect/src/translation/logical_plan/aggregate.rs 0.00% <0.00%> (ø)
...onnect/src/translation/expr/unresolved_function.rs 0.00% <0.00%> (ø)
src/daft-connect/src/translation/literal.rs 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

---- 🚨 Try these New Features:
View more details on Codecov