Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(connect): df.where #3358

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test(connect): df.where #3358

wants to merge 1 commit into from

Conversation

andrewgazelka
Copy link
Member

No description provided.

@andrewgazelka andrewgazelka marked this pull request as ready for review November 20, 2024 09:48
Copy link
Member Author

andrewgazelka commented Nov 20, 2024

@andrewgazelka andrewgazelka changed the base branch from andrew/connect-filter to graphite-base/3358 December 11, 2024 21:54
@andrewgazelka andrewgazelka changed the base branch from graphite-base/3358 to main December 11, 2024 21:55
@andrewgazelka andrewgazelka force-pushed the andrew/connect-where branch 2 times, most recently from 0c1ce76 to 9fb911a Compare December 11, 2024 22:02
Copy link

codspeed-hq bot commented Dec 11, 2024

CodSpeed Performance Report

Merging #3358 will degrade performances by 52.1%

Comparing andrew/connect-where (2ca56ef) with main (ae74c10)

Summary

❌ 1 regressions
✅ 26 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main andrew/connect-where Change
test_iter_rows_first_row[100 Small Files] 131.6 ms 274.7 ms -52.1%

@andrewgazelka andrewgazelka marked this pull request as ready for review December 11, 2024 22:12
@andrewgazelka andrewgazelka changed the title [FEAT]: connect: df.where test(connect): df.where Dec 11, 2024
@github-actions github-actions bot added the test label Dec 11, 2024
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.84%. Comparing base (ae74c10) to head (2ca56ef).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3358   +/-   ##
=======================================
  Coverage   77.84%   77.84%           
=======================================
  Files         718      718           
  Lines       88250    88250           
=======================================
+ Hits        68696    68697    +1     
+ Misses      19554    19553    -1     

see 1 file with indirect coverage changes

@andrewgazelka andrewgazelka force-pushed the andrew/connect-where branch 6 times, most recently from 11f4fe2 to 59f019b Compare December 19, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants