[FEAT] connect: createDataFrame (WIP) help needed
#3376
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 21, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| .map(|name| daft_dsl::col(name)) | ||
| .collect(); | ||
|
|
||
| let plan = plan.with_columns(column_names)? |
There was a problem hiding this comment.
Missing semicolon at the end of plan.with_columns(column_names)?. This will cause a compilation error.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
Comment on lines
+3
to
+10
| pub fn local_relation( | ||
| local_relation: spark_connect::LocalRelation, | ||
| ) -> eyre::Result<LogicalPlanBuilder> { | ||
| let spark_connect::LocalRelation { | ||
| data, | ||
| schema, | ||
| } = local_relation; | ||
| } |
There was a problem hiding this comment.
This function needs to be completed - it currently lacks a return value and implementation. The function should process the data and schema parameters to construct and return a LogicalPlanBuilder. Consider adding error handling for invalid data or schema formats.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
Comment on lines
+1
to
+3
| use eyre::{bail, WrapErr}; | ||
| use daft_logical_plan::LogicalPlanBuilder; | ||
| use crate::translation::to_logical_plan; |
There was a problem hiding this comment.
The daft_dsl crate needs to be imported to support the col() function call on line 20. Consider adding use daft_dsl; to the imports section.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
This was referenced Nov 21, 2024
andrewgazelka
force-pushed
the
andrew/connect-binary-operators
branch
from
844a0b1 to
dc3c34e
Compare
andrewgazelka
force-pushed
the
andrew/connect-createDf
branch
from
aeebe17 to
5fa8e8f
Compare
andrewgazelka
force-pushed
the
andrew/connect-binary-operators
branch
from
dc3c34e to
693574c
Compare
Graphite Automations"Warn authors when publishing large PRs" took an action on this PR • (11/21/24)1 teammate was notified to this PR based on Andrew Gazelka's automation. |
andrewgazelka
force-pushed
the
andrew/connect-createDf
branch
from
5fa8e8f to
427db3c
Compare
andrewgazelka
force-pushed
the
andrew/connect-binary-operators
branch
from
693574c to
c7f60fd
Compare
andrewgazelka
force-pushed
the
andrew/connect-createDf
branch
from
427db3c to
ef7a0bb
Compare
andrewgazelka
force-pushed
the
andrew/connect-binary-operators
branch
from
c7f60fd to
3a8c076
Compare
andrewgazelka
force-pushed
the
andrew/connect-createDf
branch
from
ef7a0bb to
f88c39c
Compare
andrewgazelka
force-pushed
the
andrew/connect-binary-operators
branch
from
3a8c076 to
4d50b1d
Compare
This was referenced Nov 21, 2024
andrewgazelka
force-pushed
the
andrew/connect-binary-operators
branch
2 times, most recently
from
8f7a067 to
54468cc
Compare
andrewgazelka
force-pushed
the
andrew/connect-createDf
branch
from
f88c39c to
b3ab393
Compare
andrewgazelka
force-pushed
the
andrew/connect-binary-operators
branch
from
54468cc to
28173ab
Compare
andrewgazelka
force-pushed
the
andrew/connect-createDf
branch
from
b3ab393 to
411958a
Compare
andrewgazelka
force-pushed
the
andrew/connect-binary-operators
branch
from
28173ab to
cdca2e2
Compare
andrewgazelka
force-pushed
the
andrew/connect-createDf
branch
from
411958a to
6ff164c
Compare
andrewgazelka
force-pushed
the
andrew/connect-binary-operators
branch
from
cdca2e2 to
fbc5c6e
Compare
andrewgazelka
force-pushed
the
andrew/connect-createDf
branch
from
6ff164c to
9457c8e
Compare
andrewgazelka
force-pushed
the
andrew/connect-binary-operators
branch
from
fbc5c6e to
a2e0beb
Compare
andrewgazelka
force-pushed
the
andrew/connect-createDf
branch
from
9457c8e to
ffc5efc
Compare
andrewgazelka
force-pushed
the
andrew/connect-binary-operators
branch
2 times, most recently
from
b9a7f70 to
3ee5757
Compare
andrewgazelka
force-pushed
the
andrew/connect-createDf
branch
2 times, most recently
from
7f6b1e3 to
464f6f5
Compare
andrewgazelka
force-pushed
the
andrew/connect-createDf
branch
from
464f6f5 to
5108778
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.