Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] connect: add modulus operator and withColumns support #3351

Merged
merged 1 commit into from
Dec 5, 2024

[FEAT] connect: add groupBy

3d691bb
Select commit
Loading
Failed to load commit list.
Merged

[FEAT] connect: add modulus operator and withColumns support #3351

[FEAT] connect: add groupBy
3d691bb
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 5, 2024 in 0s

77.36% (+0.07%) compared to 86523a0

View this Pull Request on Codecov

77.36% (+0.07%) compared to 86523a0

Details

Codecov Report

Attention: Patch coverage is 90.62500% with 3 lines in your changes missing coverage. Please review.

Project coverage is 77.36%. Comparing base (86523a0) to head (3d691bb).

Files with missing lines Patch % Lines
...onnect/src/translation/expr/unresolved_function.rs 81.81% 2 Missing ⚠️
...nnect/src/translation/logical_plan/with_columns.rs 94.73% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3351      +/-   ##
==========================================
+ Coverage   77.28%   77.36%   +0.07%     
==========================================
  Files         699      700       +1     
  Lines       85240    85274      +34     
==========================================
+ Hits        65879    65973      +94     
+ Misses      19361    19301      -60     
Files with missing lines Coverage Δ
src/daft-connect/src/translation/logical_plan.rs 87.87% <100.00%> (+7.23%) ⬆️
...nnect/src/translation/logical_plan/with_columns.rs 94.73% <94.73%> (ø)
...onnect/src/translation/expr/unresolved_function.rs 68.29% <81.81%> (+16.18%) ⬆️

... and 7 files with indirect coverage changes