Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] connect: df.schema #3353

Merged
merged 1 commit into from
Nov 26, 2024
Merged

[CHORE] connect: df.schema #3353

merged 1 commit into from
Nov 26, 2024

Conversation

andrewgazelka
Copy link
Member

No description provided.

Copy link
Member Author

andrewgazelka commented Nov 20, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@andrewgazelka andrewgazelka marked this pull request as ready for review November 20, 2024 09:12
@andrewgazelka andrewgazelka force-pushed the andrew/connect-schema branch 2 times, most recently from 9e523ac to f6f8e7d Compare November 20, 2024 23:36
@andrewgazelka andrewgazelka changed the base branch from andrew/connect-alias to graphite-base/3353 November 21, 2024 04:13
@andrewgazelka andrewgazelka changed the base branch from graphite-base/3353 to main November 21, 2024 04:17
@andrewgazelka andrewgazelka force-pushed the andrew/connect-schema branch 2 times, most recently from b22f6ee to ca7f6bd Compare November 21, 2024 04:21
@github-actions github-actions bot added the enhancement New feature or request label Nov 21, 2024
Copy link

codspeed-hq bot commented Nov 21, 2024

CodSpeed Performance Report

Merging #3353 will improve performances by ×2.4

Comparing andrew/connect-schema (f73eb15) with main (fa1d9d7)

Summary

⚡ 1 improvements
✅ 16 untouched benchmarks

Benchmarks breakdown

Benchmark main andrew/connect-schema Change
test_iter_rows_first_row[100 Small Files] 364.1 ms 153.6 ms ×2.4

Copy link

graphite-app bot commented Nov 21, 2024

Graphite Automations

"Notify author when CI fails" took an action on this PR • (11/21/24)

1 teammate was notified to this PR based on Andrew Gazelka's automation.

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.34%. Comparing base (fa1d9d7) to head (f73eb15).
Report is 14 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3353      +/-   ##
==========================================
- Coverage   77.35%   77.34%   -0.01%     
==========================================
  Files         684      684              
  Lines       83637    83637              
==========================================
- Hits        64694    64691       -3     
- Misses      18943    18946       +3     

see 2 files with indirect coverage changes

Copy link
Contributor

@universalmind303 universalmind303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can add more than a single test file for a PR. Seeing 30+ PR's is a little daunting for reviewers 😅

@andrewgazelka andrewgazelka force-pushed the andrew/connect-schema branch 2 times, most recently from 1b91ca8 to b9c9630 Compare November 21, 2024 18:45
@andrewgazelka andrewgazelka changed the title [FEAT] connect: df.schema [CHORE] connect: df.schema Nov 25, 2024
@github-actions github-actions bot added the chore label Nov 25, 2024
@kevinzwang
Copy link
Member

@andrewgazelka looks like I am assigned to this PR. Does this mean I should take on the revisions or do you actually mean to add me as a reviewer?

Copy link
Member Author

oops meant to add you are a review @kevinzwang

@andrewgazelka andrewgazelka merged commit 73f94bc into main Nov 26, 2024
47 checks passed
@andrewgazelka andrewgazelka deleted the andrew/connect-schema branch November 26, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants