Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] connect: collect #3326

Merged
merged 1 commit into from
Nov 21, 2024
Merged

[FEAT] connect: collect #3326

merged 1 commit into from
Nov 21, 2024

Conversation

andrewgazelka
Copy link
Member

No description provided.

@andrewgazelka andrewgazelka changed the title [FEAT]: connect: collect [FEAT] connect: collect Nov 18, 2024
@andrewgazelka andrewgazelka force-pushed the andrew/improve-range branch 5 times, most recently from 3901ec2 to 4f1210c Compare November 20, 2024 03:26
Copy link
Member Author

andrewgazelka commented Nov 20, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@andrewgazelka andrewgazelka mentioned this pull request Nov 20, 2024
Base automatically changed from andrew/improve-range to main November 20, 2024 03:47
@github-actions github-actions bot added the enhancement New feature or request label Nov 20, 2024
@andrewgazelka andrewgazelka changed the base branch from main to andrew/connect-consolidate-session November 20, 2024 03:52
Copy link

codspeed-hq bot commented Nov 20, 2024

CodSpeed Performance Report

Merging #3326 will improve performances by 61.17%

Comparing andrew/connect-collect (099354a) with main (5fee192)

Summary

⚡ 1 improvements
✅ 16 untouched benchmarks

Benchmarks breakdown

Benchmark main andrew/connect-collect Change
test_show[100 Small Files] 24.2 ms 15 ms +61.17%

@andrewgazelka andrewgazelka changed the base branch from andrew/fix-addr-in-use to andrew/connect-consolidate-session November 20, 2024 18:34
@andrewgazelka andrewgazelka force-pushed the andrew/connect-consolidate-session branch from 92b5258 to 98a1b86 Compare November 20, 2024 18:48
@andrewgazelka andrewgazelka force-pushed the andrew/connect-consolidate-session branch from 98a1b86 to 008b377 Compare November 20, 2024 19:31
Base automatically changed from andrew/connect-consolidate-session to main November 20, 2024 19:52
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.26%. Comparing base (5fee192) to head (099354a).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3326      +/-   ##
==========================================
- Coverage   77.41%   77.26%   -0.16%     
==========================================
  Files         678      678              
  Lines       83680    83476     -204     
==========================================
- Hits        64783    64495     -288     
- Misses      18897    18981      +84     

see 16 files with indirect coverage changes

---- 🚨 Try these New Features:

@kevinzwang
Copy link
Member

@andrewgazelka should this PR have the implementation of collect in it? I only see the test

Copy link
Member Author

It is implemented as part of the client library and not the server, so we need no implementation to get it to work.

Copy link
Member

@kevinzwang kevinzwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member Author

andrewgazelka commented Nov 21, 2024

Merge activity

  • Nov 20, 7:38 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Nov 20, 7:38 PM EST: A user merged this pull request with Graphite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants