Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] connect: add tests for df.take() method #3385

Merged
merged 1 commit into from
Nov 23, 2024

Conversation

andrewgazelka
Copy link
Member

No description provided.

Copy link
Member Author

andrewgazelka commented Nov 21, 2024

@andrewgazelka andrewgazelka changed the base branch from andrew/connect-first to graphite-base/3385 November 21, 2024 16:42
@andrewgazelka andrewgazelka changed the base branch from graphite-base/3385 to main November 21, 2024 16:43
@github-actions github-actions bot added the enhancement New feature or request label Nov 21, 2024
Copy link

codspeed-hq bot commented Nov 21, 2024

CodSpeed Performance Report

Merging #3385 will degrade performances by 61.97%

Comparing andrew/connect-take (10a3541) with main (5b36bd0)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 15 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main andrew/connect-take Change
test_iter_rows_first_row[100 Small Files] 290.4 ms 162.4 ms +78.84%
test_show[100 Small Files] 15.4 ms 40.4 ms -61.97%

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.35%. Comparing base (5b36bd0) to head (10a3541).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3385   +/-   ##
=======================================
  Coverage   77.35%   77.35%           
=======================================
  Files         684      684           
  Lines       83627    83627           
=======================================
+ Hits        64688    64691    +3     
+ Misses      18939    18936    -3     

see 2 files with indirect coverage changes

---- 🚨 Try these New Features:

@andrewgazelka andrewgazelka changed the title [FEAT] connect: add tests for df.take() method [CHORE] connect: add tests for df.take() method Nov 23, 2024
@github-actions github-actions bot added the chore label Nov 23, 2024
@andrewgazelka andrewgazelka marked this pull request as ready for review November 23, 2024 00:52
@andrewgazelka andrewgazelka merged commit 31a7abc into main Nov 23, 2024
42 of 43 checks passed
Copy link
Member Author

Merge activity

  • Nov 22, 8:13 PM EST: A user merged this pull request with Graphite.

@andrewgazelka andrewgazelka deleted the andrew/connect-take branch November 23, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants