Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add rust grpc server #1548

Merged
merged 5 commits into from
Jan 16, 2024
Merged

[ENH] Add rust grpc server #1548

merged 5 commits into from
Jan 16, 2024

Conversation

HammadB
Copy link
Collaborator

@HammadB HammadB commented Dec 18, 2023

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Adds the grpc connections for the worker
  • New functionality
    • /

Test plan

How are these changes tested?

  • Tests pass locally with cargo test

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readbility, Modularity, Intuitiveness)

Copy link
Contributor

@beggers beggers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So close I can taste it

k8s/test/coordinator_service.yaml Outdated Show resolved Hide resolved
k8s/test/segment_server_service.yml Show resolved Hide resolved
@HammadB HammadB changed the base branch from hammad/ingest_dispatch to main January 16, 2024 03:59
@HammadB HammadB merged commit a669624 into main Jan 16, 2024
95 of 98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants