Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add rust message id conversion for pulsar #1531

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Conversation

HammadB
Copy link
Collaborator

@HammadB HammadB commented Dec 15, 2023

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Adds a pulsar MsgID to our SeqID conversion based on the python version. I think we may need to revisit this encoding, as it reduces the range of the various fields, unless I am thinking about it incorrectly. For now I duplicated what we had, and we can revisit in the future.
  • New functionality
    • /

Test plan

How are these changes tested?

  • Tests pass locally with cargo test

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readbility, Modularity, Intuitiveness)

@HammadB HammadB force-pushed the hammad/rust_messageid branch from 1f059b0 to d650ad9 Compare January 15, 2024 23:54
@HammadB HammadB force-pushed the hammad/rust_messageid branch from d650ad9 to 07ec6fb Compare January 16, 2024 00:05
@HammadB HammadB force-pushed the hammad/rust_messageid branch from 07ec6fb to 446961b Compare January 16, 2024 01:18
@HammadB HammadB force-pushed the hammad/rust_messageid branch from 446961b to 81957fa Compare January 16, 2024 02:49
@HammadB HammadB changed the base branch from hammad/rust_sysdb to main January 16, 2024 02:49
@HammadB HammadB merged commit 0ab9885 into main Jan 16, 2024
98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants