Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] add Rust pulsar and topic management #1528

Merged
merged 3 commits into from
Jan 16, 2024
Merged

[ENH] add Rust pulsar and topic management #1528

merged 3 commits into from
Jan 16, 2024

Conversation

HammadB
Copy link
Collaborator

@HammadB HammadB commented Dec 15, 2023

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Adds a proper binary for the worker
    • Add an entry point for the worker the binary can use
    • Allow returning of join handles in component handles
  • New functionality
    • Adds pulsar subscriptions for the ingest, this watches the memberlist, and then spawns/removes sub-components that will subscribe to the correct stream and deserialize the message. Processing of this stream will be a following PR, this is big enough as is.
    • There are quite a few TODOs that are about error handling in here, I will do a clean up pass in a following PR.

Test plan

How are these changes tested?

  • Tests pass locally with cargo test

Documentation Changes

None required.

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readbility, Modularity, Intuitiveness)


/*
===========================================
Interfaces
===========================================
*/

/// AssignmentPolicy is a trait that defines how to assign a collection to a topic.
/// AssignmentPolicy is a trait that defines how to assign a key to a set of members.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generalizing this for any assignment

@HammadB HammadB requested a review from beggers December 15, 2023 00:15
@HammadB HammadB changed the title [ENH] add rust pulsar and topic management [ENH] add Rust pulsar and topic management Dec 15, 2023
@HammadB HammadB force-pushed the hammad/rust_memberlist_provider branch from 3f6133c to 98a83d4 Compare December 16, 2023 00:57
@HammadB HammadB force-pushed the hammad/rust_memberlist_provider branch from 98a83d4 to 69de066 Compare January 15, 2024 23:53
@HammadB HammadB force-pushed the hammad/pulsar_main branch from 11c1326 to d81042b Compare January 15, 2024 23:54
@HammadB HammadB force-pushed the hammad/rust_memberlist_provider branch from 69de066 to fbad749 Compare January 16, 2024 00:05
@HammadB HammadB force-pushed the hammad/pulsar_main branch from d81042b to 4376be2 Compare January 16, 2024 00:05
@HammadB HammadB force-pushed the hammad/rust_memberlist_provider branch from fbad749 to 6af3f4e Compare January 16, 2024 01:18
@HammadB HammadB force-pushed the hammad/pulsar_main branch from 4376be2 to 2547664 Compare January 16, 2024 01:18
@HammadB HammadB force-pushed the hammad/rust_memberlist_provider branch from 3d68387 to 93d97bd Compare January 16, 2024 01:28
@HammadB HammadB force-pushed the hammad/pulsar_main branch from 2547664 to 69eced3 Compare January 16, 2024 02:10
@HammadB HammadB changed the base branch from hammad/rust_memberlist_provider to main January 16, 2024 02:10
@HammadB HammadB force-pushed the hammad/pulsar_main branch from 69eced3 to b57e0fc Compare January 16, 2024 02:12
@HammadB HammadB enabled auto-merge (squash) January 16, 2024 02:12
@HammadB HammadB merged commit 2063588 into main Jan 16, 2024
98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants