-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Add rust hnswlib bindings, index interface #1516
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
1dd5d74
to
9c7dfab
Compare
5763f1d
to
6c4a2e8
Compare
@@ -19,6 +19,7 @@ num_cpus = "1.16.0" | |||
murmur3 = "0.5.2" | |||
thiserror = "1.0.50" | |||
num-bigint = "0.4.4" | |||
tempfile = "3.8.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move to [dev-dependencies]
Tests are failing because we need to checkout chroma-hnswlib in the worker/ CI test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reasonable and understandable. LGTM
9c7dfab
to
0de2a33
Compare
6c4a2e8
to
7e08f99
Compare
0de2a33
to
1823c17
Compare
5186023
to
06a48d6
Compare
06a48d6
to
faed752
Compare
Description of changes
Summarize the changes made by this PR.
Test plan
How are these changes tested?
Rudimentary unit tests.
cargo test
Documentation Changes
None required.