Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add component system + memberlist provider #1519

Merged
merged 6 commits into from
Jan 16, 2024

Conversation

HammadB
Copy link
Collaborator

@HammadB HammadB commented Dec 13, 2023

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • /
  • New functionality
    • Adds a component system which allows for an actor-like framework for processing messages. A component is a stateful object and its handle + sender can be used to send it messages.
    • Adds the k8s CR memberlist provider, which is a component

Test plan

How are these changes tested?
The component is tested with
The memberlist provider is currently manually tested, I will add proper intergration tests in a follow on PR

  • Tests pass locally with cargo test

Documentation Changes

None required.

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readbility, Modularity, Intuitiveness)

@HammadB HammadB changed the title Add system + basic component framework [ENH] Add component system + memberlist provider Dec 13, 2023
@HammadB HammadB requested a review from beggers December 14, 2023 18:36
).await;
}
Err(_) => {
// TODO: Log error
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving todos for logging errors, when we do a tracing/log pass we can add that in

@HammadB HammadB force-pushed the hammad/rust_hnsw_index branch from 7b63e59 to 1bbe432 Compare January 15, 2024 23:53
@HammadB HammadB force-pushed the hammad/rust_memberlist_provider branch from 98a83d4 to 69de066 Compare January 15, 2024 23:53
@HammadB HammadB force-pushed the hammad/rust_hnsw_index branch from 5186023 to 06a48d6 Compare January 16, 2024 00:05
@HammadB HammadB force-pushed the hammad/rust_memberlist_provider branch from 69de066 to fbad749 Compare January 16, 2024 00:05
@HammadB HammadB force-pushed the hammad/rust_hnsw_index branch from 06a48d6 to faed752 Compare January 16, 2024 01:14
@HammadB HammadB force-pushed the hammad/rust_memberlist_provider branch from fbad749 to 6af3f4e Compare January 16, 2024 01:18
@HammadB HammadB force-pushed the hammad/rust_memberlist_provider branch from 3d68387 to 93d97bd Compare January 16, 2024 01:28
@HammadB HammadB changed the base branch from hammad/rust_hnsw_index to main January 16, 2024 01:28
@HammadB HammadB merged commit 1217ace into main Jan 16, 2024
98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants