-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Add component system + memberlist provider #1519
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 13, 2023
1 task
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
HammadB
changed the title
Add system + basic component framework
[ENH] Add component system + memberlist provider
Dec 13, 2023
HammadB
commented
Dec 14, 2023
).await; | ||
} | ||
Err(_) => { | ||
// TODO: Log error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving todos for logging errors, when we do a tracing/log pass we can add that in
HammadB
commented
Dec 14, 2023
This was referenced Dec 15, 2023
Merged
HammadB
force-pushed
the
hammad/rust_hnsw_index
branch
from
December 16, 2023 00:57
6c4a2e8
to
7e08f99
Compare
1 task
HammadB
force-pushed
the
hammad/rust_memberlist_provider
branch
from
December 16, 2023 00:57
3f6133c
to
98a83d4
Compare
This was referenced Dec 17, 2023
beggers
approved these changes
Dec 18, 2023
beggers
approved these changes
Dec 19, 2023
HammadB
force-pushed
the
hammad/rust_hnsw_index
branch
from
January 15, 2024 23:53
7b63e59
to
1bbe432
Compare
HammadB
force-pushed
the
hammad/rust_memberlist_provider
branch
from
January 15, 2024 23:53
98a83d4
to
69de066
Compare
HammadB
force-pushed
the
hammad/rust_hnsw_index
branch
from
January 16, 2024 00:05
5186023
to
06a48d6
Compare
HammadB
force-pushed
the
hammad/rust_memberlist_provider
branch
from
January 16, 2024 00:05
69de066
to
fbad749
Compare
HammadB
force-pushed
the
hammad/rust_hnsw_index
branch
from
January 16, 2024 01:14
06a48d6
to
faed752
Compare
HammadB
force-pushed
the
hammad/rust_memberlist_provider
branch
from
January 16, 2024 01:18
fbad749
to
6af3f4e
Compare
HammadB
force-pushed
the
hammad/rust_memberlist_provider
branch
from
January 16, 2024 01:28
3d68387
to
93d97bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Summarize the changes made by this PR.
Test plan
How are these changes tested?
The component is tested with
The memberlist provider is currently manually tested, I will add proper intergration tests in a follow on PR
cargo test
Documentation Changes
None required.