-
Notifications
You must be signed in to change notification settings - Fork 0
Developer Guidelines
If you have a patch or pull request for us, thank you!
The more of these guidelines you can follow, the easier (and faster) it is for us to evaluate your code and incorporate it into the development branch.
(Borrowing from ThinkUp's Pull Request Checklist):
-
Make sure you can perform a full build and that the tests all pass. (See Building and Testing)
-
Please try to add unit tests to demonstrate that your submission fixes an existing bug, or performs as intended.
-
Rebase your branch on the current state of the
development
branch. Usegit rebase development
. This means you might have to deal with conflicts. -
Consolidate commits so that all related file changes are within a single commit. You can squash commits into a single commit by doing
git rebase -i
. -
Be descriptive in your commit messages: explain the purpose of all changes. You can modify commit messages by doing
git commit --amend
(for the previous change), orgit rebase -i
for earlier changes.
Once your branch is cleaned up, please submit the Pull request against the development
branch.
Thanks for your help!