Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump dependencies #3958

Merged
merged 10 commits into from
Jul 24, 2024
Merged

chore: bump dependencies #3958

merged 10 commits into from
Jul 24, 2024

Conversation

thofma
Copy link
Collaborator

@thofma thofma commented Jul 20, 2024

No description provided.

Copy link

codecov bot commented Jul 20, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.10%. Comparing base (dae843c) to head (b35e687).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3958   +/-   ##
=======================================
  Coverage   84.09%   84.10%           
=======================================
  Files         593      593           
  Lines       81757    81757           
=======================================
+ Hits        68757    68758    +1     
+ Misses      13000    12999    -1     
Files Coverage Δ
experimental/IntersectionTheory/src/blowup.jl 98.48% <100.00%> (ø)
...ntal/SymmetricIntersections/src/representations.jl 96.65% <100.00%> (ø)
src/Groups/matrices/linear_isconjugate.jl 100.00% <100.00%> (ø)
src/Modules/UngradedModules/FreeMod.jl 84.31% <ø> (ø)
src/NumberTheory/GaloisGrp/GaloisGrp.jl 78.15% <100.00%> (ø)
src/NumberTheory/GaloisGrp/Qt.jl 67.63% <100.00%> (ø)
src/Groups/matrices/stuff_field_gen.jl 61.11% <50.00%> (ø)

... and 1 file with indirect coverage changes

@thofma thofma closed this Jul 22, 2024
@thofma thofma reopened this Jul 22, 2024
@lgoettgens lgoettgens closed this Jul 22, 2024
@lgoettgens lgoettgens reopened this Jul 22, 2024
@benlorenz
Copy link
Member

benlorenz commented Jul 22, 2024

It looks like this needs another update for the GenericCharacterTables:
https://github.com/oscar-system/Oscar.jl/actions/runs/10042679900/job/27753670388?pr=3958#step:9:534

The code also uses Generic.UniversalPolyRing with two type parameters:
https://github.com/oscar-system/GenericCharacterTables.jl/blob/cd48ab9c38d8476b1bfcedd47e68e1b3d2e688d7/src/CharTable.jl#L24
https://github.com/oscar-system/GenericCharacterTables.jl/blob/cd48ab9c38d8476b1bfcedd47e68e1b3d2e688d7/src/CharTable.jl#L33

And there seem to be some deprecated calls to is_power (Nemocas/Nemo.jl#1830) in the docs:

* `is_power(a::QQFieldElem, b::Int) -> Bool, QQFieldElem`
Test if ``a`` is an ``n``-th power. If so, return ```true``` and the root,
```false``` and any rational otherwise.
* `is_power(a::QQFieldElem) -> Int, QQFieldElem`
Find the largest ``n`` such that ``a`` is an ``n``-th power. Return ``n`` and the root.
* `root(a::QQFieldElem, b::Int) -> QQFieldElem`
Compute an ``n``-th root of ``a``, raises an error if ``a`` is not an ``n``-th power.
```jldoctest
julia> is_power(QQ(8), 3)
(true, 2)
julia> is_power(QQ(8), 2)
(false, 8)
julia> is_power(QQ(9//16))

(and maybe more?)

@lgoettgens
Copy link
Member

See oscar-system/GenericCharacterTables.jl#87 for resolving the remaining problems with GCT.jl

@lgoettgens lgoettgens closed this Jul 23, 2024
@lgoettgens lgoettgens reopened this Jul 23, 2024
@lgoettgens
Copy link
Member

GCT.jl 0.3 includes a breaking change for the OSCAR book. See oscar-system/GenericCharacterTables.jl#88 for details. This issue will unfortunately block this PR here.

@thofma thofma marked this pull request as ready for review July 24, 2024 09:03
Copy link
Member

@lgoettgens lgoettgens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally! LGTM

@lgoettgens
Copy link
Member

@benlorenz could you please have a look at the change in the booktest setup? I think this should be more or less what we talked about yesterday, but I wanna make sure that it is. For more details see #3958 (comment)

@lgoettgens
Copy link
Member

@benlorenz could you please have a look at the change in the booktest setup? I think this should be more or less what we talked about yesterday, but I wanna make sure that it is. For more details see #3958 (comment)

We just had a look at this together and he approved the change orally.

@thofma thofma enabled auto-merge (squash) July 24, 2024 09:55
@thofma thofma merged commit ed7e3bb into master Jul 24, 2024
30 checks passed
@thofma thofma deleted the th/buuuump branch July 24, 2024 09:56
ooinaruhugh pushed a commit to ooinaruhugh/Oscar.jl that referenced this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants