-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump dependencies #3958
chore: bump dependencies #3958
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3958 +/- ##
=======================================
Coverage 84.09% 84.10%
=======================================
Files 593 593
Lines 81757 81757
=======================================
+ Hits 68757 68758 +1
+ Misses 13000 12999 -1
|
It looks like this needs another update for the GenericCharacterTables: The code also uses And there seem to be some deprecated calls to Oscar.jl/docs/src/Rings/rational.md Lines 271 to 291 in e548b0d
(and maybe more?) |
See oscar-system/GenericCharacterTables.jl#87 for resolving the remaining problems with GCT.jl |
GCT.jl 0.3 includes a breaking change for the OSCAR book. See oscar-system/GenericCharacterTables.jl#88 for details. This issue will unfortunately block this PR here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally! LGTM
@benlorenz could you please have a look at the change in the booktest setup? I think this should be more or less what we talked about yesterday, but I wanna make sure that it is. For more details see #3958 (comment) |
We just had a look at this together and he approved the change orally. |
No description provided.