Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More updates for universal polynomials #87

Merged
merged 3 commits into from
Jul 23, 2024

Conversation

lgoettgens
Copy link
Member

To get oscar-system/Oscar.jl#3958 going.

I verified locally, that with this branch the GCT.jl tests succeed both with AA 0.41.x (via Oscar 1.1.1) and with AA 0.42.0 (via https://github.com/oscar-system/Oscar.jl/tree/th/buuuump).

It would be great if @fingolfin could merge and release this so that we can proceed with oscar-system/Oscar.jl#3958.

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.16%. Comparing base (cd48ab9) to head (bea6a28).

❗ There is a different number of reports uploaded between BASE (cd48ab9) and HEAD (bea6a28). Click for more details.

HEAD has 5 uploads less than BASE
Flag BASE (cd48ab9) HEAD (bea6a28)
6 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master      #87       +/-   ##
===========================================
- Coverage   70.37%   44.16%   -26.22%     
===========================================
  Files          10       10               
  Lines         908      908               
===========================================
- Hits          639      401      -238     
- Misses        269      507      +238     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fingolfin fingolfin merged commit caa7890 into oscar-system:master Jul 23, 2024
6 of 8 checks passed
@lgoettgens lgoettgens deleted the lg/more-univpoly branch July 23, 2024 09:23
lgoettgens added a commit to lgoettgens/GenericCharacterTables.jl that referenced this pull request Jul 23, 2024
thofma pushed a commit that referenced this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants