Replace edpm_network_config_template with existing _override #243
Conversation
|
/hold |
|
We need to fix CI to adjust for this change in the dataplane-operator CI pipeline. |
|
Build failed (check pipeline). For information on how to proceed, see https://review.rdoproject.org/zuul/buildset/3a4d6d64af5248efb23b45eecc804fa3 ✔️ edpm-ansible-molecule-edpm-podman SUCCESS in 5m 31s |
bshephar
force-pushed
the
nic-config-override
branch
2 times, most recently
from
21f59e0 to
75e4065
Compare
This change updates the nic-config samples and documentation to reflect the changes made in: openstack-k8s-operators/edpm-ansible#243 Signed-off-by: Brendan Shephard <[email protected]>
|
Build failed (check pipeline). For information on how to proceed, see https://review.rdoproject.org/zuul/buildset/6ad14c134a0447038fcc81b9d0589537 ✔️ edpm-ansible-molecule-edpm-podman SUCCESS in 5m 13s |
This change updates the nic-config samples and documentation to reflect the changes made in: openstack-k8s-operators/edpm-ansible#243 Depends-On: openstack-k8s-operators/edpm-ansible#243 Signed-off-by: Brendan Shephard <[email protected]>
This change updates the nic-config samples and documentation to reflect the changes made in: openstack-k8s-operators/edpm-ansible#243 Signed-off-by: Brendan Shephard <[email protected]>
bshephar
force-pushed
the
nic-config-override
branch
from
75e4065 to
20ae93c
Compare
|
Build failed (check pipeline). For information on how to proceed, see https://review.rdoproject.org/zuul/buildset/5fbe9aae6c4045449a7c43dfacf61237 ✔️ edpm-ansible-molecule-edpm-podman SUCCESS in 6m 10s |
There was a problem hiding this comment.
I understand where this is going, and I think I can get behind it. It does however have the implication that you can't use our packaged templates in the role templates dir without reproducing the content into the DataPlane resource. Hard to say how many users have actually done that historically, which is why I say I can get behind this, but I do think it's worth raising for broader awareness. May want input from the hardprov folks.
Yeah, good point. I'll loop them in for awareness. I can't think of any situation where I have seen a user using our default network configuration files. But it would definitely be nice to get some more eyes on it to make sure we're not taking functionality away from anyone. |
This change updates the nic-config samples and documentation to reflect the changes made in: openstack-k8s-operators/edpm-ansible#243 Signed-off-by: Brendan Shephard <[email protected]>
This change updates the nic-config samples and documentation to reflect the changes made in: openstack-k8s-operators/edpm-ansible#243 Signed-off-by: Brendan Shephard <[email protected]>
|
What's holding this one up at this point? Do we just need the CI change? We might need both vars for a time to land this without breaking CI. Then we can come back around and delete the _override var once CI is updated. So the steps would be:
|
This change updates the nic-config samples and documentation to reflect the changes made in: openstack-k8s-operators/edpm-ansible#243 Signed-off-by: Brendan Shephard <[email protected]>
This change updates the nic-config samples and documentation to reflect the changes made in: openstack-k8s-operators/edpm-ansible#243 Signed-off-by: Brendan Shephard <[email protected]>
This change updates the nic-config samples and documentation to reflect the changes made in: openstack-k8s-operators/edpm-ansible#243 Signed-off-by: Brendan Shephard <[email protected]>
This change updates the nic-config samples and documentation to reflect the changes made in: openstack-k8s-operators/edpm-ansible#243 Signed-off-by: Brendan Shephard <[email protected]>
This change updates the nic-config samples and documentation to reflect the changes made in: openstack-k8s-operators/edpm-ansible#243 Signed-off-by: Brendan Shephard <[email protected]>
This change updates the nic-config samples and documentation to reflect the changes made in: openstack-k8s-operators/edpm-ansible#243 Signed-off-by: Brendan Shephard <[email protected]>
This change updates the nic-config samples and documentation to reflect the changes made in: openstack-k8s-operators/edpm-ansible#243 Signed-off-by: Brendan Shephard <[email protected]>
This change removes the CRD level override for network config files. Instead, this allows us to use the Ansible variable directly to set any require network config customizations. Depends-On: openstack-k8s-operators/edpm-ansible#243 Signed-off-by: Brendan Shephard <[email protected]>
This change removes the CRD level override for network config files. Instead, this allows us to use the Ansible variable directly to set any require network config customizations. Depends-On: openstack-k8s-operators/edpm-ansible#243 Signed-off-by: Brendan Shephard <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bshephar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
+2 But we need to wait for the Depends-On and to see it work with openstack-k8s-operators/dataplane-operator#394 |
This change removes the CRD level override for network config files. Instead, this allows us to use the Ansible variable directly to set any require network config customizations. Depends-On: openstack-k8s-operators/edpm-ansible#243 Signed-off-by: Brendan Shephard <[email protected]>
This change removes the CRD level override for network config files. Instead, this allows us to use the Ansible variable directly to set any require network config customizations. Depends-On: openstack-k8s-operators/edpm-ansible#243 Signed-off-by: Brendan Shephard <[email protected]>
This change removes the CRD level override for network config files. Instead, this allows us to use the Ansible variable directly to set any require network config customizations. Depends-On: openstack-k8s-operators/edpm-ansible#243 Signed-off-by: Brendan Shephard <[email protected]>
This change removes the CRD level override for network config files. Instead, this allows us to use the Ansible variable directly to set any require network config customizations. Depends-On: openstack-k8s-operators/edpm-ansible#243 Signed-off-by: Brendan Shephard <[email protected]>
This change removes the CRD level override for network config files. Instead, this allows us to use the Ansible variable directly to set any require network config customizations. Depends-On: openstack-k8s-operators/edpm-ansible#243 Signed-off-by: Brendan Shephard <[email protected]>
This change removes the CRD level override for network config files. Instead, this allows us to use the Ansible variable directly to set any require network config customizations. Depends-On: openstack-k8s-operators/edpm-ansible#243 Signed-off-by: Brendan Shephard <[email protected]>
This change removes the CRD level override for network config files. Instead, this allows us to use the Ansible variable directly to set any require network config customizations. Depends-On: openstack-k8s-operators/edpm-ansible#243 Signed-off-by: Brendan Shephard <[email protected]>
This change removes the CRD level override for network config files. Instead, this allows us to use the Ansible variable directly to set any require network config customizations. Depends-On: openstack-k8s-operators/edpm-ansible#243 Signed-off-by: Brendan Shephard <[email protected]>
This change removes the CRD level override for network config files. Instead, this allows us to use the Ansible variable directly to set any require network config customizations. Depends-On: openstack-k8s-operators/edpm-ansible#243 Signed-off-by: Brendan Shephard <[email protected]>
This change removes the CRD level override for network config files. Instead, this allows us to use the Ansible variable directly to set any require network config customizations. Depends-On: openstack-k8s-operators/edpm-ansible#243 Signed-off-by: Brendan Shephard <[email protected]>
This change removes the CRD level override for network config files. Instead, this allows us to use the Ansible variable directly to set any require network config customizations. Depends-On: openstack-k8s-operators/edpm-ansible#243 Signed-off-by: Brendan Shephard <[email protected]>
This change removes the CRD level override for network config files. Instead, this allows us to use the Ansible variable directly to set any require network config customizations. Depends-On: openstack-k8s-operators/edpm-ansible#243 Signed-off-by: Brendan Shephard <[email protected]>
We have removed the bespoke API interface used to override nic-config files in favor or the direct Ansible variable. This change ensures that we don't remove the variable from the template, which is currently using the standard single-nic-vlans.j2 file: https://github.com/openstack-k8s-operators/dataplane-operator/pull/394/files openstack-k8s-operators/edpm-ansible#243 Signed-off-by: Brendan Shephard <[email protected]>
This change removes the CRD level override for network config files. Instead, this allows us to use the Ansible variable directly to set any require network config customizations. Depends-On: openstack-k8s-operators/edpm-ansible#243 Signed-off-by: Brendan Shephard <[email protected]>
This change removes the CRD level override for network config files. Instead, this allows us to use the Ansible variable directly to set any require network config customizations. Depends-On: openstack-k8s-operators/edpm-ansible#243 Signed-off-by: Brendan Shephard <[email protected]>
We have removed the bespoke API interface used to override nic-config files in favor or the direct Ansible variable. This change ensures that we don't remove the variable from the template, which is currently using the standard single-nic-vlans.j2 file: https://github.com/openstack-k8s-operators/dataplane-operator/pull/394/files openstack-k8s-operators/edpm-ansible#243 Signed-off-by: Brendan Shephard <[email protected]>
We have removed the bespoke API interface used to override nic-config files in favor or the direct Ansible variable. This change ensures that we don't remove the variable from the template, which is currently using the standard single-nic-vlans.j2 file: https://github.com/openstack-k8s-operators/dataplane-operator/pull/394/files openstack-k8s-operators/edpm-ansible#243 Signed-off-by: Brendan Shephard <[email protected]>
We have removed the bespoke API interface used to override nic-config files in favor or the direct Ansible variable. This change ensures that we don't remove the variable from the template, which is currently using the standard single-nic-vlans.j2 file: https://github.com/openstack-k8s-operators/dataplane-operator/pull/394/files openstack-k8s-operators/edpm-ansible#243 Signed-off-by: Brendan Shephard <[email protected]>
We have removed the bespoke API interface used to override nic-config files in favor or the direct Ansible variable. This change ensures that we don't remove the variable from the template, which is currently using the standard single-nic-vlans.j2 file: https://github.com/openstack-k8s-operators/dataplane-operator/pull/394/files openstack-k8s-operators/edpm-ansible#243 Signed-off-by: Brendan Shephard <[email protected]>
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Broke this up into more backwards compatible PR's. The last of which is this one: |
Given the way this interface is leveraged via the dataplane-operator, it
doesn't make sense to define a file path. Instead, this change moves the
existing edpm_network_config_override to be the primary interface. It
has subsequently been renamed to edpm_network_config_template.
This allows users to define jinja2 strings for the variable, and they are
rendered out to compute nodes using the copy module.
Depends-On: openstack-k8s-operators/install_yamls#451