Update nic-config samples and docs #318
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bshephar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
bshephar
force-pushed
the
nic-config-sample
branch
2 times, most recently
from
d326985 to
2665585
Compare
Given the way this interface is leveraged via the dataplane-operator, it doesn't make sense to define a file path. Instead, this change moves the existing edpm_network_config_override to be the primary interface. It has subsequently been renamed to edpm_network_config_template. This allows users to define jinja2 strings for the variable, and they are rendered out to compute nodes using the copy module. Depends-On: openstack-k8s-operators/dataplane-operator#318 Signed-off-by: Brendan Shephard <[email protected]>
|
Build failed (check pipeline). For information on how to proceed, see https://review.rdoproject.org/zuul/buildset/295738a4d8cf44fda5965b83d253405e ✔️ dataplane-operator-docs-preview SUCCESS in 1m 55s |
|
There is a env var[1] in install_yamls used to change the template[2] atm. It has to be dropped too. [1] https://github.com/openstack-k8s-operators/install_yamls/blob/main/Makefile#L285 |
bshephar
force-pushed
the
nic-config-sample
branch
from
2665585 to
776a40c
Compare
This change updates the nic-config samples and documentation to reflect the changes made in: openstack-k8s-operators/edpm-ansible#243 Signed-off-by: Brendan Shephard <[email protected]>
Thanks @rabi . Did I understand your comment correctly with this PR? |
|
@bshephar: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Closing this PR in favor of I cherry-picked this commit to that PR to keep everything in one place. |
Given the way this interface is leveraged via the dataplane-operator, it doesn't make sense to define a file path. Instead, this change moves the existing edpm_network_config_override to be the primary interface. It has subsequently been renamed to edpm_network_config_template. This allows users to define jinja2 strings for the variable, and they are rendered out to compute nodes using the copy module. Depends-On: openstack-k8s-operators/dataplane-operator#318 Signed-off-by: Brendan Shephard <[email protected]>
Given the way this interface is leveraged via the dataplane-operator, it doesn't make sense to define a file path. Instead, this change moves the existing edpm_network_config_override to be the primary interface. It has subsequently been renamed to edpm_network_config_template. This allows users to define jinja2 strings for the variable, and they are rendered out to compute nodes using the copy module. Depends-On: openstack-k8s-operators/dataplane-operator#318 Signed-off-by: Brendan Shephard <[email protected]>
Given the way this interface is leveraged via the dataplane-operator, it doesn't make sense to define a file path. Instead, this change moves the existing edpm_network_config_override to be the primary interface. It has subsequently been renamed to edpm_network_config_template. This allows users to define jinja2 strings for the variable, and they are rendered out to compute nodes using the copy module. Depends-On: openstack-k8s-operators/dataplane-operator#318 Signed-off-by: Brendan Shephard <[email protected]>
This change updates the nic-config samples and documentation to reflect the changes made in:
openstack-k8s-operators/edpm-ansible#243