Use default single-nic-vlans.j2 #560
Conversation
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/73e5400d53c74af0bbbb3308b7966a0a ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 32m 02s |
|
Uhmmm failed to apply the first networking config https://logserver.rdoproject.org/60/560/add973e5615e1274650ff306e019205226536103/github-check/podified-multinode-edpm-deployment-crc/9a818ed/controller/ci-framework-data/artifacts/must-gather.local.2949961155780841694/quay-io-openstack-k8s-operators-openstack-must-gather-sha256-070a98749455b097c66a1a25ff827a3c0ee7385f1f0c8bf54f5b15438501f2bd/namespaces/openstack/pods/dataplane-deployment-configure-network-openstack-edpm-24wqc/logs/dataplane-deployment-configure-network-openstack-edpm-24wqc.log and after that the compute was unreachable (see the other logs from the other pods of the same job). |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/817396e640d441b891a3940c57ab07f4 Warning: |
|
@bshephar Ok I see, the change that removes it from install_yamls and the dataplane is not yet in, just ping me when you need this one in. |
|
Maybe using |
bshephar
force-pushed
the
remove-networkconfig
branch
2 times, most recently
from
0c6fd83 to
0e18c87
Compare
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/445d114db6534b678aa1193d69fdc6b3 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 30m 59s |
I have the Depends-On for the dataplane-operator PR so that it Depends-On this PR: Do you think it should be the other way around? |
|
recheck |
|
Ops, wrong PR to recheck. My bad. |
This change removes the CRD level override for network config files. Instead, this allows us to use the Ansible variable directly to set any require network config customizations. Depends-On: openstack-k8s-operators/edpm-ansible#341 Depends-On: openstack-k8s-operators/ci-framework#560 Signed-off-by: Brendan Shephard <[email protected]>
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/84f71ea192c341d9b17a03571d137834 ✔️ openstack-k8s-operators-content-provider SUCCESS in 50m 18s |
bshephar
force-pushed
the
remove-networkconfig
branch
from
0e18c87 to
989893b
Compare
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/6a4d1d8ba4514957a5687bc03c7e528f ✔️ openstack-k8s-operators-content-provider SUCCESS in 48m 46s |
This change removes the CRD level override for network config files. Instead, this allows us to use the Ansible variable directly to set any require network config customizations. Depends-On: openstack-k8s-operators/edpm-ansible#341 Depends-On: openstack-k8s-operators/ci-framework#560 Signed-off-by: Brendan Shephard <[email protected]>
This change removes the CRD level override for network config files. Instead, this allows us to use the Ansible variable directly to set any require network config customizations. Depends-On: openstack-k8s-operators/edpm-ansible#341 Depends-On: openstack-k8s-operators/ci-framework#560 Signed-off-by: Brendan Shephard <[email protected]>
This change removes the CRD level override for network config files. Instead, this allows us to use the Ansible variable directly to set any require network config customizations. Depends-On: openstack-k8s-operators/edpm-ansible#341 Depends-On: openstack-k8s-operators/ci-framework#560 Signed-off-by: Brendan Shephard <[email protected]>
We have removed the bespoke API interface used to override nic-config files in favor or the direct Ansible variable. This change ensures that we don't remove the variable from the template, which is currently using the standard single-nic-vlans.j2 file: https://github.com/openstack-k8s-operators/dataplane-operator/pull/394/files openstack-k8s-operators/edpm-ansible#243 Signed-off-by: Brendan Shephard <[email protected]>
bshephar
force-pushed
the
remove-networkconfig
branch
from
989893b to
2eed4b1
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pablintino The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This change removes the CRD level override for network config files. Instead, this allows us to use the Ansible variable directly to set any require network config customizations. Depends-On: openstack-k8s-operators/edpm-ansible#341 Depends-On: openstack-k8s-operators/ci-framework#560 Signed-off-by: Brendan Shephard <[email protected]>
This change removes the CRD level override for network config files. Instead, this allows us to use the Ansible variable directly to set any require network config customizations. Depends-On: openstack-k8s-operators/edpm-ansible#341 Depends-On: openstack-k8s-operators/ci-framework#560 Signed-off-by: Brendan Shephard <[email protected]>
openshift-merge-robot
merged commit 6f6d85b
into
openstack-k8s-operators:main
We have removed the bespoke API interface used to override nic-config files in favor or the direct Ansible variable. This change ensures that we don't remove the variable from the template, which is currently using the standard single-nic-vlans.j2 file:
https://github.com/openstack-k8s-operators/dataplane-operator/pull/394/files
openstack-k8s-operators/edpm-ansible#243
As a pull request owner and reviewers, I checked that: