Fix typo in hive role

[lewisdenny]

This PR fixes a warning reported by ansible-lint [1]

[1] WARNING Unable to resolve FQCN for module ansible.builtin.include_task

As a pull request owner and reviewers, I checked that:

• Appropriate testing is done and actually running
• Appropriate documentation exists and/or is up-to-date:
  • README in the role
  • Content of the docs/source is reflecting the changes

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/13487cd870a14f1ba03c0d9d031fb1ea

✔️ openstack-k8s-operators-content-provider SUCCESS in 51m 55s
❌ podified-multinode-edpm-deployment-crc FAILURE in 36m 38s
✔️ noop SUCCESS in 0s
❌ podified-multinode-edpm-e2e-nobuild-tagged-crc FAILURE in 39m 55s
✔️ cifmw-molecule-hive SUCCESS in 4m 48s

[psathyan]

/lgtm

[lewisdenny]

I think we have an issue here, I'm getting the same failure locally as well:

TASK [edpm_kustomize : Apply the already existing kustomization if present output_dir={{ cifmw_edpm_kustomize_artifacts_dir }}, chdir={{ cifmw_edpm_kustomize_cr_path | dirname }}, script=oc kustomize  -o {{ cifmw_edpm_kustomize_cr_path }}] ***
task path: /ldenny/ci-framework/ci_framework/roles/edpm_kustomize/tasks/kustomize.yml:37
The full traceback is:
NoneType: None
fatal: [localhost]: FAILED! => {
    "changed": true,
    "msg": "non-zero return code",
    "rc": 1,
    "stderr": "",
    "stderr_lines": [],
    "stdout": "~/ci-framework-data/artifacts/manifests/openstack/dataplane/cr ~/ci-framework-data/artifacts\nerror: replace operation does not apply: doc is missing path: /spec/deployStrategy/deploy: missing value\n",
    "stdout_lines": [
        "~/ci-framework-data/artifacts/manifests/openstack/dataplane/cr ~/ci-framework-data/artifacts",
        "error: replace operation does not apply: doc is missing path: /spec/deployStrategy/deploy: missing value"
    ]
}

Just leaving this hear until later.

[cjeanner]

/approve

It seems to need an install_yamls change:
openstack-k8s-operators/install_yamls#534
(as well as openstack-k8s-operators/install_yamls#538 for BM)

IIRC we also have an open PR for that one, probably #560.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjeanner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [cjeanner]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[bshephar]

/approve

It seems to need an install_yamls change: openstack-k8s-operators/install_yamls#534 (as well as openstack-k8s-operators/install_yamls#538 for BM)

IIRC we also have an open PR for that one, probably #560.

Yeah, the two install_yamls PR's are needed to fix that. It's because the deployStrategy was removed by:
openstack-k8s-operators/dataplane-operator@ff7bbd6#diff-1135163039ac7c4a64ba5b6a225ad7225316c9ed0e7d42f1079d3d630a25120aL127

The PR you referenced of mine for ci-framework is removing the NetworkConfig part of the API, so unrelated to this specific failure.

[pablintino]

recheck

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/b40c1f92be374009a79095fe28e43731

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 22m 42s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 57m 27s
✔️ noop SUCCESS in 0s
❌ podified-multinode-edpm-e2e-nobuild-tagged-crc FAILURE in 52m 54s
✔️ cifmw-molecule-hive SUCCESS in 5m 06s

[lewisdenny]

recheck