Add templating support for nmstate defined networking configuration #249
Conversation
rebtoor
force-pushed
the
nmstate
branch
3 times, most recently
from
28e6061 to
f6e6003
Compare
|
Build failed (check pipeline). For information on how to proceed, see https://review.rdoproject.org/zuul/buildset/db8ce9184af042449b73528d9e3780f4 ✔️ edpm-ansible-molecule-edpm-podman SUCCESS in 6m 02s |
|
it's useless to "recheck" the CI, job is already passed on baremetal. |
roles/edpm_network_config/templates/system_role_nmstate/single_nic_vlans.j2
Outdated
Show resolved
Hide resolved
|
Build failed (check pipeline). For information on how to proceed, see https://review.rdoproject.org/zuul/buildset/c2f711664f204d55a96d1573dcd17434 ✔️ edpm-ansible-molecule-edpm-podman SUCCESS in 5m 18s |
|
recheck |
|
Build failed (check pipeline). For information on how to proceed, see https://review.rdoproject.org/zuul/buildset/f2d17fe3d771432eb2aa3fd4927acd2b ✔️ edpm-ansible-molecule-edpm-podman SUCCESS in 5m 23s |
|
Build failed (check pipeline). For information on how to proceed, see https://review.rdoproject.org/zuul/buildset/9dba68c3df0b48caba29d63ae451c1ee ✔️ edpm-ansible-molecule-edpm-podman SUCCESS in 5m 12s |
| @@ -40,5 +40,6 @@ edpm_network_config_os_net_config_mappings: {} | |||
| edpm_network_config_safe_defaults: true | |||
| edpm_network_config_with_ansible: true | |||
| edpm_network_config_template: templates/single_nic_vlans/single_nic_vlans.j2 | |||
| edpm_network_config_nmstate_template: templates/system_role_nmstate/single_nic_vlans.j2 | |||
There was a problem hiding this comment.
Rather than making this a file path, which is only really useful for CI can we do a similar thing to this PR?
#243
So instead of having a template file, we can in-line the yaml which will work better for the dataplane-operator CRD interface?
Which means the Dataplane operator CRD interface would look like:
https://github.com/openstack-k8s-operators/dataplane-operator/pull/318/files#diff-7c43891912d609cdc0e86a9cb67c44e43264d6e6463d9afa2726a1292cf749caR57-R90
Since users can't realistically use a filepath template file.
There was a problem hiding this comment.
I should have read the conversation history before my comment. I see this was discussed above too.
There was a problem hiding this comment.
I modified the role following your PRs examples. I also drop edpm_network_config_nmstate_template (re)using edpm_network_config_template var because otherwise we should handle this case here: https://github.com/openstack-k8s-operators/dataplane-operator/pull/284/files#diff-874aae70e738f15dc1bf30750cee0e87e3278c5c02d37e35c0943ca6c29393bb
|
/hold we need to understand if we want to go on with the path described in: #243 |
|
This change depends on a change that failed to merge. Change openstack-k8s-operators/dataplane-operator#284 is needed. |
rebtoor
force-pushed
the
nmstate
branch
2 times, most recently
from
b4b5743 to
d17c7b5
Compare
|
/unhold |
* Fixed `nmstate` molecule scenario for `edpm_network_config` role Signed-off-by: Roberto Alfieri <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rebtoor, slagle The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
merged commit 9323b53
into
openstack-k8s-operators:main
nmstatemolecule scenario foredpm_network_configrole