Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(RingTheory/Polynomial/HilbertPoly): the definition and key property of Polynomial.hilbertPoly p d for p : F[X] and d : ℕ, where F is a field. #19303

Closed
wants to merge 18 commits into from

Conversation

FMLJohn
Copy link
Collaborator

@FMLJohn FMLJohn commented Nov 20, 2024

Given any field F, polynomial p : F[X] and natural number d, we have defined Polynomial.hilbertPoly p d : F[X]. If F is of characteristic zero, then for any large enough n : ℕ, PowerSeries.coeff F n (p * (invOneSubPow F d)) equals (hilbertPoly p d).eval (n : F) (see Polynomial.coeff_mul_invOneSubPow_eq_hilbertPoly_eval).

@FMLJohn FMLJohn added t-algebraic-geometry Algebraic geometry t-algebra Algebra (groups, rings, fields, etc) labels Nov 20, 2024
Copy link

github-actions bot commented Nov 20, 2024

PR summary fe4cf0e8c1

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.RingTheory.Polynomial.HilbertPoly (new file) 1043

Declarations diff

+ ascFactorial_eq_prod_range
+ ascPochhammer_nat_eq_natCast_ascFactorial
+ ascPochhammer_nat_eq_natCast_descFactorial
+ coeff_mul_invOneSubPow_eq_hilbertPoly_eval
+ hilbertPoly
+ hilbertPoly_X_pow_succ
+ hilbertPoly_poly_succ
+ hilbertPoly_poly_zero
+ hilbertPoly_zero_nat
+ invOneSubPow_inv_zero_eq_one
+ preHilbertPoly
+ preHilbertPoly_eq_choose_sub_add
- invOneSubPow_inv_eq_one_of_eq_zero

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@FMLJohn FMLJohn changed the title Feat(RingTheory/Polynomial/Hilbert): the Hilbert polynomial in terms of a natural number d and a polynomial p : ℤ[X] feat(RingTheory/Polynomial/Hilbert): the Hilbert polynomial in terms of a natural number d and a polynomial p : ℤ[X] Nov 22, 2024
@FMLJohn FMLJohn changed the title feat(RingTheory/Polynomial/Hilbert): the Hilbert polynomial in terms of a natural number d and a polynomial p : ℤ[X] feat(RingTheory/Polynomial/Hilbert): the definition of the Hilbert polynomial in terms of a natural number d and a polynomial p : ℤ[X] Nov 23, 2024
Mathlib/RingTheory/PowerSeries/WellKnown.lean Show resolved Hide resolved
scripts/noshake.json Outdated Show resolved Hide resolved
Mathlib/RingTheory/Polynomial/Hilbert.lean Outdated Show resolved Hide resolved
Mathlib/RingTheory/Polynomial/Hilbert.lean Outdated Show resolved Hide resolved
@FMLJohn FMLJohn changed the title feat(RingTheory/Polynomial/Hilbert): the definition of the Hilbert polynomial in terms of a natural number d and a polynomial p : ℤ[X] feat(RingTheory/Polynomial/Hilbert): the definition of the Hilbert polynomial in terms of a natural number d and a polynomial p : F[X], where F is a field with characteristic 0. Nov 28, 2024
@FMLJohn FMLJohn changed the title feat(RingTheory/Polynomial/Hilbert): the definition of the Hilbert polynomial in terms of a natural number d and a polynomial p : F[X], where F is a field with characteristic 0. feat(RingTheory/Polynomial/Hilbert): the definition and key property of Polynomial.hilbert p d for a natural number d and a polynomial p : F[X]. Nov 30, 2024
@FMLJohn FMLJohn changed the title feat(RingTheory/Polynomial/Hilbert): the definition and key property of Polynomial.hilbert p d for a natural number d and a polynomial p : F[X]. feat(RingTheory/Polynomial/Hilbert): the definition and key property of Polynomial.hilbert p d for a natural number d and a polynomial p : F[X], where F is a field. Nov 30, 2024
@FMLJohn FMLJohn changed the title feat(RingTheory/Polynomial/Hilbert): the definition and key property of Polynomial.hilbert p d for a natural number d and a polynomial p : F[X], where F is a field. feat(RingTheory/Polynomial/Hilbert): the definition and key property of Polynomial.hilbert p d, where F is a field, p : F[X] and d : ℕ. Nov 30, 2024
Mathlib/RingTheory/Polynomial/Hilbert.lean Outdated Show resolved Hide resolved
Mathlib/RingTheory/Polynomial/Hilbert.lean Outdated Show resolved Hide resolved
Mathlib/RingTheory/Polynomial/Hilbert.lean Outdated Show resolved Hide resolved
Mathlib/RingTheory/Polynomial/Hilbert.lean Outdated Show resolved Hide resolved
Mathlib/RingTheory/Polynomial/Hilbert.lean Outdated Show resolved Hide resolved
@kbuzzard
Copy link
Member

Thanks a lot for your work on this!

maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by kbuzzard.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Dec 1, 2024
@FMLJohn FMLJohn changed the title feat(RingTheory/Polynomial/Hilbert): the definition and key property of Polynomial.hilbert p d for p : F[X] and d : ℕ, where F is a field. feat(RingTheory/Polynomial/Hilbert): the definition and key property of RatFunc.Polynomial.hilbert p d for p : F[X] and d : ℕ, where F is a field. Dec 1, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Dec 1, 2024
@jcommelin jcommelin added the awaiting-author A reviewer has asked the author a question or requested changes label Dec 2, 2024
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Dec 2, 2024

✌️ FMLJohn can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added delegated and removed awaiting-author A reviewer has asked the author a question or requested changes labels Dec 2, 2024
@FMLJohn FMLJohn changed the title feat(RingTheory/Polynomial/Hilbert): the definition and key property of RatFunc.Polynomial.hilbert p d for p : F[X] and d : ℕ, where F is a field. feat(RingTheory/Polynomial/Hilbert): the definition and key property of Polynomial.hilbertPoly p d for p : F[X] and d : ℕ, where F is a field. Dec 2, 2024
@FMLJohn FMLJohn changed the title feat(RingTheory/Polynomial/Hilbert): the definition and key property of Polynomial.hilbertPoly p d for p : F[X] and d : ℕ, where F is a field. feat(RingTheory/Polynomial/HilbertPoly): the definition and key property of Polynomial.hilbertPoly p d for p : F[X] and d : ℕ, where F is a field. Dec 2, 2024
@FMLJohn
Copy link
Collaborator Author

FMLJohn commented Dec 2, 2024

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Dec 2, 2024
…rty of `Polynomial.hilbertPoly p d` for `p : F[X]` and `d : ℕ`, where `F` is a field. (#19303)

Given any field `F`, polynomial `p : F[X]` and natural number `d`, we have defined `Polynomial.hilbertPoly p d : F[X]`. If `F` is of characteristic zero, then for any large enough `n : ℕ`, `PowerSeries.coeff F n (p * (invOneSubPow F d))` equals `(hilbertPoly p d).eval (n : F)` (see `Polynomial.coeff_mul_invOneSubPow_eq_hilbertPoly_eval`).
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Dec 2, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(RingTheory/Polynomial/HilbertPoly): the definition and key property of Polynomial.hilbertPoly p d for p : F[X] and d : ℕ, where F is a field. [Merged by Bors] - feat(RingTheory/Polynomial/HilbertPoly): the definition and key property of Polynomial.hilbertPoly p d for p : F[X] and d : ℕ, where F is a field. Dec 2, 2024
@mathlib-bors mathlib-bors bot closed this Dec 2, 2024
@mathlib-bors mathlib-bors bot deleted the hilbert branch December 2, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated maintainer-merge t-algebra Algebra (groups, rings, fields, etc) t-algebraic-geometry Algebraic geometry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants