-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(RingTheory/Polynomial/Hilbert): given a natural number d
and a polynomial p : ℤ[X]
, proved the key property of the Hilbert polynomial in terms of d
and p
#19404
Open
FMLJohn
wants to merge
15
commits into
master
Choose a base branch
from
hilbert_property
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+28
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FMLJohn
added
t-algebraic-geometry
Algebraic geometry
t-algebra
Algebra (groups, rings, fields, etc)
labels
Nov 23, 2024
PR summary 24b0b96bf5Import changes exceeding 2%
|
File | Base Count | Head Count | Change |
---|---|---|---|
Mathlib.RingTheory.Polynomial.HilbertPoly | 1046 | 1094 | +48 (+4.59%) |
Import changes for all files
Files | Import difference |
---|---|
Mathlib.RingTheory.Polynomial.HilbertPoly |
48 |
Declarations diff
+ exists_unique_hilbertPoly
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>
The doc-module for script/declarations_diff.sh
contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relative
value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolute
value is therelative
value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
mathlib4-dependent-issues-bot
added
the
blocked-by-other-PR
This PR depends on another PR to Mathlib (this label is automatically managed by a bot)
label
Nov 23, 2024
leanprover-community-bot-assistant
added
the
merge-conflict
The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot)
label
Dec 2, 2024
mathlib4-dependent-issues-bot
removed
the
blocked-by-other-PR
This PR depends on another PR to Mathlib (this label is automatically managed by a bot)
label
Dec 2, 2024
This PR/issue depends on: |
leanprover-community-bot-assistant
removed
the
merge-conflict
The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot)
label
Dec 3, 2024
github-actions
bot
added
the
large-import
Automatically added label for PRs with a significant increase in transitive imports
label
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
large-import
Automatically added label for PRs with a significant increase in transitive imports
t-algebra
Algebra (groups, rings, fields, etc)
t-algebraic-geometry
Algebraic geometry
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Polynomial.hilbertPoly p d
forp : F[X]
andd : ℕ
, whereF
is a field. #19303In this pull request, we have proved the key property of the Hilbert polynomial in terms of a natural number
d
and a polynomialp : ℤ[X]
(Polynomial.coeff_mul_invOneSubPow_eq_hilbert_eval
), i.e. for any term ofp * (invOneSubPow ℤ d)
whose degree is large enough, its coefficient can be obtained by evaluating the Hilbert polynomial.The codes are much longer than needed. Further editing is needed.