Reduce error to debug msg for mesh construction #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <[email protected]>
ahcorde
approved these changes
Aug 22, 2023
Codecov Report
@@ Coverage Diff @@
## main #531 +/- ##
=======================================
Coverage 77.15% 77.15%
=======================================
Files 139 139
Lines 7603 7603
=======================================
Hits 5866 5866
Misses 1737 1737
|
|
This is related to #450. |
azeey
approved these changes
Aug 23, 2023
8 tasks
iche033
added a commit
that referenced
this pull request
Dec 11, 2023
Signed-off-by: Ian Chen <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]>
ahcorde
added a commit
that referenced
this pull request
Dec 11, 2023
Signed-off-by: Ian Chen <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
Currently gazebo prints out error messages if the model has a mesh collision. The collision seems to be created fine but gz-physics still prints out an error msg:
[Err] [SDFFeatures.cc:843] The geometry element of collision [Rock01_Collider_62] couldn't be createdWhen you have lots of mesh collisions in the world like in the harmonic demo, the console is filled with red error msgs.
Taking a similar approach as in #452, this PR just downgrades the severity level from error to debug.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.