Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport mesh construction error to debug msg (#531) #581

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Dec 11, 2023

🦟 Bug fix

Backport of #531

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (5b74d1f) 78.59% compared to head (fad4342) 78.59%.

Files Patch % Lines
dartsim/src/SDFFeatures.cc 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           gz-physics6     #581   +/-   ##
============================================
  Coverage        78.59%   78.59%           
============================================
  Files              140      140           
  Lines             7654     7654           
============================================
  Hits              6016     6016           
  Misses            1638     1638           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ahcorde ahcorde merged commit 216f174 into gz-physics6 Dec 11, 2023
12 of 14 checks passed
@ahcorde ahcorde deleted the construct_sdf_mesh_error_backport branch December 11, 2023 19:05
@caguero caguero mentioned this pull request Jun 12, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants