Decode #13 #17

nelsonic · 2020-04-25T21:15:31Z

This PR:

Adds the decode/1 function Base58 decode #13
Adds guard clauses for integer, float and atom values. Why :error when data is not binary? #14
Enhanced the README.md: https://github.com/dwyl/base58/tree/decode-issue%2313

It can only be merged once we've looked at the the Module name; currently Base58Encode #16
Publishing a new version is dependent on #15

…ecode* #13

codecov · 2020-04-25T21:16:54Z

Codecov Report

Merging #17 into master will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #17   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           14        20    +6     
=========================================
+ Hits            14        20    +6

Impacted Files	Coverage Δ
lib/base58.ex	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c56a724...9c23a62. Read the comment docs.

…function #13) see #16

nelsonic · 2020-04-25T22:38:50Z

@SimonLab please see: https://github.com/dwyl/base58/tree/decode-issue%2313

nelsonic · 2020-04-26T10:51:20Z

test/base58_test.exs

@@ -0,0 +1,88 @@
+defmodule Base58Test do


Don't know why GitHub thinks this is a new file, I just renamed it.
.then added a few new tests. 📝

nelsonic · 2020-04-26T10:52:08Z

mix.exs

@@ -1,13 +1,13 @@
-defmodule Base58Encode.MixProject do
+defmodule Base58.MixProject do


lib/base58.ex

SimonLab

to_char_list can be replaced by to_charlist
The example is not running as it tries to called the module with the old name.

I'm going to create a commit to fix these two points above.
Otherwise looks good

Co-Authored-By: Simon <[email protected]>

…issue#13

SimonLab

I've added the following commit to fix the example: #17
PR looks good.
I'll let you double check my changes @nelsonic and happy for you to merge the PR 👍

nelsonic · 2020-04-27T12:09:09Z

example/example.exs

@@ -1,8 +1,10 @@
 defmodule Example do

  hello = "hello"
-  helloBase58 = Base58Encode.encode(hello)
+  helloBase58 = Base58.encode(hello)


@SimonLab thanks for updating the example. 👍

nelsonic · 2020-04-27T12:12:36Z

@SimonLab thanks for updating the example. 👍
I cannot approve/merge my own PR:

Please merge if you're happy with it.
merci bowcups. 😉

nelsonic added 7 commits April 25, 2020 11:44

rename Base58encode to just Base58 to reflect the fact that we can *d…

10084f1

…ecode* #13

convert any value to binary then encode as Base58 #14

33d8705

rename to exbase58

b70fc66

create .formatter.exs file to format code

b4cbb93

add implementation of Base58.decode fixes #13

e9d2b05

rename test

326a5fe

bump package version to 1.0.0 (SemVer) includes decode function! #13

2d43962

nelsonic added the awaiting-review label Apr 25, 2020

nelsonic assigned nelsonic and SimonLab Apr 25, 2020

nelsonic added 8 commits April 25, 2020 23:17

update dependencies

97b46bd

update module name to b58 #16

501e3e4

rename module from Base58Encode to Base58 (as we now have a decode/1 …

42fcf6b

…function #13) see #16

update docs in README.md with example usage for Base58.decode/1 #13

9af3c7a

close <div align="center"> to tidy up readme

18771d5

add base58 hero image in README.md

19e066e

add elixir code formatting to example blocks in README.md

f822d39

fix module name in installation instructions :b58 #16

ec2cdf6

nelsonic mentioned this pull request Apr 25, 2020

Base58 decode #13

Closed

nelsonic requested a review from SimonLab April 25, 2020 22:38

nelsonic removed their assignment Apr 25, 2020

nelsonic mentioned this pull request Apr 25, 2020

Use Base58 for API Keys dwyl/auth#49

Closed

2 tasks

nelsonic added 4 commits April 26, 2020 10:15

add note on encoding/decoding integer values #14

07b11c5

update version of ex_doc in mix.exs

6ea4d4c

create decode_to_int/1 to decode integer values #14

c184aea

add note on encoding/decoding integer values to README.md #14

279fd7a

nelsonic mentioned this pull request Apr 26, 2020

Why :error when data is not binary? #14

Closed

fix markdown errors

c1a484b

nelsonic commented Apr 26, 2020

View reviewed changes

mix.exs

@@ -1,13 +1,13 @@

defmodule Base58Encode.MixProject do

defmodule Base58.MixProject do

Copy link

Member Author

nelsonic Apr 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename #16

nelsonic mentioned this pull request Apr 27, 2020

Please Add @dwyl as Co-owner of b58 Hex.pm Package #15

Closed

SimonLab reviewed Apr 27, 2020

View reviewed changes

lib/base58.ex Outdated Show resolved Hide resolved

SimonLab reviewed Apr 27, 2020

View reviewed changes

nelsonic and others added 3 commits April 27, 2020 13:00

Update to_char_list > to_charlist lib/base58.ex

dca4ee7

Co-Authored-By: Simon <[email protected]>

fix example and use to_charlist, #17

fdf7f23

Merge branch 'decode-issue#13' of github.com:dwyl/base58 into decode-…

9c23a62

…issue#13

SimonLab approved these changes Apr 27, 2020

View reviewed changes

SimonLab assigned nelsonic and unassigned SimonLab Apr 27, 2020

nelsonic commented Apr 27, 2020

View reviewed changes

SimonLab merged commit e817934 into master Apr 27, 2020

SimonLab deleted the decode-issue#13 branch April 27, 2020 13:28

nelsonic mentioned this pull request Apr 27, 2020

Module name Base58Encode ? #16

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Decode #13 #17

Decode #13 #17

nelsonic commented Apr 25, 2020 •

edited

Loading

codecov bot commented Apr 25, 2020 •

edited

Loading

nelsonic commented Apr 25, 2020

nelsonic Apr 26, 2020

nelsonic Apr 26, 2020

SimonLab left a comment •

edited

Loading

SimonLab left a comment

nelsonic Apr 27, 2020

nelsonic commented Apr 27, 2020

		@@ -1,13 +1,13 @@
		defmodule Base58Encode.MixProject do
		defmodule Base58.MixProject do

Decode #13 #17

Decode #13 #17

Conversation

nelsonic commented Apr 25, 2020 • edited Loading

codecov bot commented Apr 25, 2020 • edited Loading

Codecov Report

nelsonic commented Apr 25, 2020

nelsonic Apr 26, 2020

Choose a reason for hiding this comment

nelsonic Apr 26, 2020

Choose a reason for hiding this comment

SimonLab left a comment • edited Loading

Choose a reason for hiding this comment

SimonLab left a comment

Choose a reason for hiding this comment

nelsonic Apr 27, 2020

Choose a reason for hiding this comment

nelsonic commented Apr 27, 2020

nelsonic commented Apr 25, 2020 •

edited

Loading

codecov bot commented Apr 25, 2020 •

edited

Loading

SimonLab left a comment •

edited

Loading