Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module name Base58Encode ? #16

Closed
nelsonic opened this issue Apr 25, 2020 · 1 comment
Closed

Module name Base58Encode ? #16

nelsonic opened this issue Apr 25, 2020 · 1 comment
Assignees
@SimonLab
Labels
awaiting-review discuss enhancement New feature or request T25m technical

Comments

@nelsonic
Copy link
Member

At present the name of the module in this package is Base58Encode:
https://github.com/dwyl/exbase58/blob/c56a72407fa6f8b09423d9461206fafec68bc809/lib/base58encode.ex#L1

Given that we need to the ability to decode #13 for dwyl/auth#49
I propose that we rename it to B58 or Base58 (used by base58) or ExBase58 (unique namespace)
@nelsonic nelsonic mentioned this issue Apr 25, 2020
Merged
3 tasks
nelsonic added a commit that referenced this issue Apr 25, 2020
@nelsonic
update module name to b58 #16
501e3e4
nelsonic added a commit that referenced this issue Apr 25, 2020
@nelsonic
rename module from Base58Encode to Base58 (as we now have a decode/1 …
42fcf6b 
…function #13) see #16
nelsonic added a commit that referenced this issue Apr 25, 2020
@nelsonic
fix module name in installation instructions :b58 #16
ec2cdf6
@nelsonic
Copy link
Member Author

Merged in #17 ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SimonLab SimonLab

Labels
awaiting-review discuss enhancement New feature or request T25m technical
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nelsonic @SimonLab