Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Base58 for API Keys #49

Closed
2 tasks done
nelsonic opened this issue Apr 24, 2020 · 5 comments
Closed
2 tasks done

Use Base58 for API Keys #49

nelsonic opened this issue Apr 24, 2020 · 5 comments
Assignees
@SimonLab
Labels
awaiting-review An issue or pull request that needs to be reviewed chore a tedious but necessary task often paying technical debt enhancement New feature or enhancement of existing functionality T25m Time Estimate 25 Minutes

Comments

@nelsonic
Copy link
Member

nelsonic commented Apr 24, 2020 •
edited by SimonLab
Loading

At present the AUTH_API_KEY PR #42 is using exbase58 for Base58 encoding/decoding.
We need to:
@nelsonic nelsonic added the enhancement New feature or enhancement of existing functionality label Apr 24, 2020
@nelsonic nelsonic self-assigned this Apr 24, 2020
@nelsonic
Copy link
Member Author

Sadly the https://github.com/dwyl/base58encode project is one-way ...
We need the ability decode the encoded values so that we can decrypt them.
So we need to spend some time on dwyl/base58#13 ⏳

@nelsonic nelsonic mentioned this issue Apr 25, 2020
Closed
@nelsonic
Copy link
Member Author

I've added the ability to decode Base58 in dwyl/base58#17 :shipit:

nelsonic added a commit that referenced this issue Apr 25, 2020
@nelsonic
use exbase58 to encode API Keys to Base58 for #49
152146c
nelsonic added a commit that referenced this issue Apr 25, 2020
@nelsonic
use Base58.encode in apikey_controller.ex #49
81c790f
@nelsonic
Copy link
Member Author

image

@nelsonic nelsonic mentioned this issue Apr 26, 2020
Closed
@nelsonic
Copy link
Member Author

nelsonic commented May 1, 2020

@SimonLab once #43 is merged we can create a separate PR to replace exbase58 (temporary) with b58 (LTS). It should be a drop-in replacement as the OTP App has the same name.

@nelsonic nelsonic assigned SimonLab and unassigned nelsonic May 1, 2020
@nelsonic nelsonic added chore a tedious but necessary task often paying technical debt T25m Time Estimate 25 Minutes labels May 1, 2020
SimonLab added a commit that referenced this issue May 13, 2020
@SimonLab
use b58 instead of exbase58, #49 (comment)
fa512c5
@SimonLab SimonLab mentioned this issue May 13, 2020
Merged
@SimonLab SimonLab added the awaiting-review An issue or pull request that needs to be reviewed label May 13, 2020
@nelsonic
Copy link
Member Author

Thanks for getting this done @SimonLab 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SimonLab SimonLab

Labels
awaiting-review An issue or pull request that needs to be reviewed chore a tedious but necessary task often paying technical debt enhancement New feature or enhancement of existing functionality T25m Time Estimate 25 Minutes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nelsonic @SimonLab