Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Base58 decode #13

Closed
rupurt opened this issue Apr 22, 2019 · 3 comments
Closed

Base58 decode #13

rupurt opened this issue Apr 22, 2019 · 3 comments
Assignees
@SimonLab
Labels
awaiting-review question Further information is requested starter T2h technical

Comments

@rupurt
Copy link

rupurt commented Apr 22, 2019

Do you have any plans to add support for decode?
@nelsonic nelsonic added question Further information is requested starter technical labels Apr 22, 2019
@nelsonic nelsonic mentioned this issue Apr 25, 2020
Closed
2 tasks
@nelsonic nelsonic added the T2h label Apr 25, 2020
@nelsonic
Copy link
Member

@rupurt thanks for opening this issue. We are working on this today.

@nelsonic nelsonic self-assigned this Apr 25, 2020
nelsonic added a commit that referenced this issue Apr 25, 2020
@nelsonic
rename Base58encode to just Base58 to reflect the fact that we can *d…
10084f1 
…ecode* #13
@rupurt
Copy link
Author

rupurt commented Apr 25, 2020

Sweet! Look forward to it.

nelsonic added a commit that referenced this issue Apr 25, 2020
@nelsonic
bump package version to 1.0.0 (SemVer) includes decode function! #13
2d43962
This was referenced Apr 25, 2020
Closed
Merged
nelsonic added a commit that referenced this issue Apr 25, 2020
@nelsonic
rename module from Base58Encode to Base58 (as we now have a decode/1 …
42fcf6b 
…function #13) see #16
nelsonic added a commit that referenced this issue Apr 25, 2020
@nelsonic
update docs in README.md with example usage for Base58.decode/1 #13
9af3c7a
@nelsonic
Copy link
Member

PR ready for review: #17

@nelsonic nelsonic assigned SimonLab and unassigned nelsonic Apr 26, 2020
SimonLab added a commit that referenced this issue Apr 27, 2020
@SimonLab
Merge pull request #17 from dwyl/decode-issue#13
e817934 
Decode #13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SimonLab SimonLab

Labels
awaiting-review question Further information is requested starter T2h technical
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nelsonic @rupurt @SimonLab