New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address Benedikt Wagner Audit comments #246

Open

kevaundray opened this issue Sep 2, 2024 · 0 comments

Contributor

kevaundray commented Sep 2, 2024

This is a tracking issue to address all of the changes that @b-wagn has brought up in his initial review of the codebase.

PRs addressing those comments will link to this issue.

This was referenced Sep 5, 2024

chore: Address Initial low hanging internal audit comments #248

Merged

Change OpeningKey to VerificationKey/VerifierKey #249

Closed

Is embedding an instance of the verifier in the prover, the right abstraction? #250

Closed

Redundant check in recover_polynomial_coeff? #251

Closed

Inconsistent naming for trusted setup secret #252

Closed

Add Doc comment for FK20Verifier field members coset_shifts_pow_n and inv_coset_shifts_pow_n #253

Closed

Standardize on terminology: coset_shifts vs coset_gens #254

Closed

Consider moving verify_multi_opening outside of FK20 #255

Open

Consider splitting up verify_multi_opening into more modular functions #256

Closed

Feedback on the Reed-Solomon module #257

Open

Standardize on Terminology: DFT vs FFT #258

Closed

Consider introducing a FFT trait #259

Closed

Consider having an FFT module instead of implementing these in Domain #260

Closed

Consider unrolling take_even_odd to remove the if statement #261

Closed

Consider renaming monomial.rs #262

Closed

Consider adding the poly_add, poly_sub and other polynomial related functions as methods onto PolyCoeff #263

Closed

Replace usage of Scalar::from(0u64) and Scalar::from(1u64) with Scalar::ZERO and Scalar::ONE #264

Closed

Consider adding an assert for constructor in OpeningKey #265

Closed

Standardize on terminology: r(X) vs I(x) #266

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment