Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize on terminology: coset_shifts vs coset_gens #254

Closed
kevaundray opened this issue Sep 5, 2024 · 3 comments
Closed

Standardize on terminology: coset_shifts vs coset_gens #254

kevaundray opened this issue Sep 5, 2024 · 3 comments

Comments

@kevaundray
Copy link
Contributor

This has been taken from Benedikt Wagner's document.

We use coset_shifts and coset_gens interchangeably to mean the same thing.

Link:

let coset_shifts = coset_gens(num_points_to_open, num_cosets, BIT_REVERSED);

Related to #246

@b-wagn
Copy link

b-wagn commented Sep 6, 2024

No strong opinion on which of them is better. Maybe check the spec: it uses shifts here. So maybe go with shifts?

@kevaundray
Copy link
Contributor Author

closed by #281

@kevaundray
Copy link
Contributor Author

Noted in the PR, I went with coset_gens short for coset_generators since I didn't think coset_shifts is well-defined; they are just generators for a coset. It might make sense to change it in the specs but no hard opinion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants