Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider adding the poly_add, poly_sub and other polynomial related functions as methods onto PolyCoeff #263

Closed
kevaundray opened this issue Sep 5, 2024 · 1 comment
Closed

Consider adding the poly_add, poly_sub and other polynomial related functions as methods onto PolyCoeff #263

kevaundray opened this issue Sep 5, 2024 · 1 comment
Labels
internal-audit

Comments

@kevaundray
Copy link
Contributor

This has been taken from Benedikt Wagner's document.

This may make them more convenient to use.

Note: This would require making PolyCoeff a struct and not a type alias.

Related to #246
@kevaundray kevaundray changed the title Consider adding the poly_add, poly_sub and other polynomial related functions as methods ono PolyCoeff Consider adding the poly_add, poly_sub and other polynomial related functions as methods onto PolyCoeff Sep 26, 2024
@kevaundray
Copy link
Contributor Author

For this, I'll leave as is since these methods are essentially only used for testing and implementing a naive version of the protocol, so not much is gained in the code that actually gets called.

Wouldn't be against a PR to make the change though

@kevaundray kevaundray closed this as not planned Won't fix, can't repro, duplicate, stale Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
internal-audit
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kevaundray