Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is embedding an instance of the verifier in the prover, the right abstraction? #250

Closed
kevaundray opened this issue Sep 5, 2024 · 0 comments · Fixed by #290
Closed

Is embedding an instance of the verifier in the prover, the right abstraction? #250

kevaundray opened this issue Sep 5, 2024 · 0 comments · Fixed by #290
Labels
internal-audit

Comments

@kevaundray
Copy link
Contributor

This has been taken from Benedikt Wagner's document.

Currently recovery code lives inside of the verifier. Since we added recover_cells_and_compute_proofs which is a method on the prover. An instance of the verifier is now embedded in the prover.

From the document, it was suggested to possibly create a third entity that does "recovery" and that is what we put in the verifier and prover.

Related to #246
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
internal-audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: move recovery code to its own module crate-crypto/rust-eth-kzg
1 participant
@kevaundray