Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider moving verify_multi_opening outside of FK20 #255

Open
kevaundray opened this issue Sep 5, 2024 · 1 comment
Open

Consider moving verify_multi_opening outside of FK20 #255

kevaundray opened this issue Sep 5, 2024 · 1 comment

Comments

@kevaundray
Copy link
Contributor

This has been taken from Benedikt Wagner's document.

There is a comment here re why its currently there:

/// Note: Although this method is on the `FK20Verifier` structure, it is possible to verify methods that are not

Related to #246

I'm still on the fence about it from a code organization perspective -- note that all of our "internal naive" provers have their own verifiers for simplicity. Though the complexity might just be an artifact of the current architecture. We could have a "provers" and "verifiers" folder for example, and the verifiers are just naive and optimized.

@b-wagn
Copy link

b-wagn commented Sep 6, 2024

We could have a "provers" and "verifiers" folder for example, and the verifiers are just naive and optimized.

That sounds reasonable to me 👍 But I understand that it requires a non-trivial restructuring of the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants