-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Internationalising CSV output #341
Comments
Also Excel. & also headers of Excel/CSV |
Can roll out a bit at a time - do other 2 first then ENUM one. May want to rewrite ENUM handling at same time. |
I updated the description a little bit providing a breakdown of required work |
#341 Alter JS so locale key added to URL's Ignore locale key when checking for valid filters Start using flask-babel Set up our 2 current translations, with only one translated string (from Google Translate) Translate headers in CSV & XLSX So headers are picked up, duplicate at the top of iati_datastore/iatilib/frontend/serialize/csv.py (Added TODO to fix this later) Update README with instructions Add compile strings stage to deploy
#341 Alter JS so locale key added to URL's Ignore locale key when checking for valid filters Start using flask-babel Set up our 2 current translations, with only one translated string (from Google Translate) Translate headers in CSV & XLSX So headers are picked up, duplicate at the top of iati_datastore/iatilib/frontend/serialize/csv.py (Added TODO to fix this later) Update README with instructions Add compile strings stage to deploy
#341 Alter JS so locale key added to URL's Ignore locale key when checking for valid filters Start using flask-babel Set up our 2 current translations, with no translated strings. Translate headers in CSV & XLSX So headers are picked up, duplicate at the top of iati_datastore/iatilib/frontend/serialize/csv.py (Added TODO to fix this later) Update README with instructions Add compile strings stage to deploy Fix tests
#341 Alter JS so locale key added to URL's Ignore locale key when checking for valid filters Start using flask-babel Set up our 2 current translations, with no translated strings. Set up custom extractor to get CSV column headings. Translate headers in CSV & XLSX Update README with instructions Add compile strings stage to deploy Fix tests
Have begun looking a this, have a couple of clarifying questions see below. |
Description types
|
Locales
|
Hello @radix0000 and welcome! Looking forward to working together, especially after such an insightful first few comments here :) Description types - you are right. We should keep all description types, and yes we should add these as new columns. Your column headers are good. Also agree with description_general containing a fall-back to the most general description if there is not a description of type 1. Locale - I agree that it is nice to be flexible with which languages we can support, but there are a number of constraints:
The internationalisation of the output will depend particularly on (2) above, and the accessibility will depend on (3), so requesting another language might not get the user very far. But if it is not complicated to implement then why not allow other languages and fall back to EN CSV headers and codelists if these are not available in the requested language? NB the preferred language is already automatically set if the user's language is other than English -- try changing the preferred language in your browser and then going to the interface. I can see why you might want to download French versions of the files using the English interface but I don't think we should bother worrying about that right now, as the user can just switch to the French interface. |
Is your feature request related to a problem? Please describe.
Users can now select different languages in the front-end interface. However, the data is still output in EN.
Describe the solution you’d like
For CSV and Excel exports:
NB relevant codelists can be retrieved from here: https://codelists.codeforiati.org/
The initially-supported languages should be: EN, FR, ES, PT
Note that we don't yet have complete translations for every codelist in each of these languages, but we will work on this separately.
Describe alternatives you’ve considered
Using CDFD: https://countrydata.iatistandard.org
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: